From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [patch: first impression] Date: Tue, 25 Oct 2022 14:15:57 +0300 Message-ID: <83a65kp30y.fsf@gnu.org> References: <87fsgyuyh7.fsf@mat.ucm.es> <878rlmim4q.fsf@mat.ucm.es> <7ae1356e-ff81-5445-ab6f-bf431678bf69@yandex.ru> <877d16fgfr.fsf@mat.ucm.es> <0cc26283-3e36-d418-6f72-99fa31304a9d@yandex.ru> <87sfjmgoya.fsf@mat.ucm.es> <87v8oh63oq.fsf@mat.ucm.es> <084455a1-cd60-1350-6947-964f255f912e@yandex.ru> <87o7u945xu.fsf@mat.ucm.es> <5df61fcd-f085-c59a-1389-2573fdce40d7@yandex.ru> <877d0x3zwx.fsf@mat.ucm.es> <9fa5fa58-d7f2-bb79-e6c6-be01c7edc065@yandex.ru> <87y1td84fc.fsf@mat.ucm.es> <0bffec65-14d7-cf3f-5005-741790bc6d5e@yandex.ru> <87ilkhx7i4.fsf@web.de> <87v8ogcqwt.fsf@mat.ucm.es> <9508331b-ed94-060d-ff9a-018031cf59c4@yandex.ru> <87o7u12q5l.fsf@mat.ucm.es> <5108ef1b-60cd-bb17-722b-ba62684cb4d4@yandex.ru> <87tu3spb70.fsf@gmail.com> <87mt9k1czw.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13673"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, dgutov@yandex.ru, oub@mat.ucm.es, arne_bab@web.de, georges.racinet@octobus.net, emacs-devel@gnu.org To: Uwe Brauer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 25 13:20:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onHzO-0003I1-1Q for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Oct 2022 13:20:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onHuv-00015S-19; Tue, 25 Oct 2022 07:16:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onHur-0000n1-HD for emacs-devel@gnu.org; Tue, 25 Oct 2022 07:16:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onHup-000305-R9; Tue, 25 Oct 2022 07:16:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LTayhe0Y7hUZ7Vfz4FftroABwf595Q8O4xPOMYfyqhg=; b=ot+niGPCYiroN7LQLxV+ Izc4nsCgf9fjn8fwqUwgMreGEVxt0juihyXklBAjXu6+vQXNLYFFlKaMcelwDG5c1SWFmcnkytDKR oOCVUdNaxUTIP2yTezeb0tGscuiCsEHs1tOld+ZZiOu4cTshdsJCd8T647YnhbfnlRkzDDnNEhH38 6CJBau54MQd0zLGUt0Y9tMVRPa+paMz+utnHb+tCOV734Zoe2XR4ZSADfArt5byiOyEVnSEG795Xi zrqgsCG0dGpV4s8GJuGHwQZeXExEUougVQYEzBJH3XOWhwV6BRVo5rBECRh8NqSwEmuEyk/MhTVro oazqkFk1gr0Dgw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onHuk-0001dI-1c; Tue, 25 Oct 2022 07:16:15 -0400 In-Reply-To: <87mt9k1czw.fsf@mat.ucm.es> (message from Uwe Brauer on Tue, 25 Oct 2022 11:14:27 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298452 Archived-At: > From: Uwe Brauer > Cc: Dmitry Gutov , Uwe Brauer , > "Dr. Arne Babenhauserheide" , > georges.racinet@octobus.net, emacs-devel@gnu.org > Date: Tue, 25 Oct 2022 11:14:27 +0200 > > > Deleting hunks is already supported: > > > k runs the command diff-hunk-kill (found in diff-mode-shared-map), > > which is an interactive byte-compiled Lisp function in `diff-mode.el'. > > > It is bound to k and M-k. > > > (diff-hunk-kill) > > > Kill the hunk at point. > > Thanks, I think I mentioned that > > > Extending that to support a prefix count arg and the region shouldnʼt > > be too hard. > > I am not sure that prefix count would be that useful (I wouldn't count > hunk before deleting them in mass. It sounds a bit like a keyboard > macro) I think we should support an argument to mean the count of hunks to delete. And negative arguments should kill backward. Every Emacs command that kills does (or at least should) behave like that, and I think this is a nice and convenient consistency. > Deleting regions would be nice, however Only complete hunks in the region, I guess? Deleting partial hunks will make the diffs invalid.