From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Eglot: auto-import completion item Date: Thu, 17 Nov 2022 11:50:19 +0200 Message-ID: <83a64pewpw.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32657"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Marcin Pajkowski , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 17 10:50:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovbXh-0008CU-J5 for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Nov 2022 10:50:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovbXK-0003cN-KZ; Thu, 17 Nov 2022 04:50:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovbXI-0003Zw-3R for emacs-devel@gnu.org; Thu, 17 Nov 2022 04:50:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovbXH-0002C7-H8; Thu, 17 Nov 2022 04:50:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=C0G2yVC8+IFHAlEQva7Nf8l9O5Zjv6Bzsbgx3IaDp/8=; b=sUVuP/1O4otte4n2p0pK gyLfsnKWmvc22jSP+Bg4jOPCq5RNlzK3JFpuIsfwyMIvZfzf6Hbbdmf4lmxdeRQjz401oMbhx4MVo x/BqAuX/5KYyWLSGQ2Pe31ACICXt88xkI5ZlVIRBUQZZFxaLcqYzRN6OXAPNOlm3fM+v3OT+W1kSA 36+mJO/FJTriA5+vWs+3H9tL6QDZGYoJ0RdgG3QWuBPtdznmjJKdsj75w27/HaV9Mmow0MmLaH+pr 1nsjDJmxkNrhG8B1vFlyXDKiB8w+vtHFDkXWW4ZVxPbEDplvD2QzGKxJpaCYCTgJibkieYQvfYWiT rVlHRzklKelKiw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovbXF-0005zI-SI; Thu, 17 Nov 2022 04:50:19 -0500 In-Reply-To: (message from Marcin Pajkowski on Sat, 12 Nov 2022 14:23:52 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300032 Archived-At: > From: Marcin Pajkowski > Date: Sat, 12 Nov 2022 14:23:52 +0100 > > * lisp/progmodes/eglot.el (eglot-client-capabilities): Advertise > resolveSupport capabilities > --- > lisp/progmodes/eglot.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 63ebbe6cab..953c0f45fc 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -736,6 +736,7 @@ eglot-client-capabilities > t > :json-false) > :deprecatedSupport t > + :resolveSupport (:properties ["documentation" "details" "additionalTextEdits"]) > :tagSupport (:valueSet [1])) > :contextSupport t) > :hover (list :dynamicRegistration :json-false > -- > 2.38.1 João, what about this one? Should we install it? What are resolveSupport capabilities about?