From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: emacs-devel@gnu.org, joaotavora@gmail.com
Subject: Re: Add cl-defgeneric project-name; first use case eglot
Date: Mon, 21 Nov 2022 15:07:49 +0200 [thread overview]
Message-ID: <83a64k4fru.fsf@gnu.org> (raw)
In-Reply-To: <86zgcll1le.fsf@stephe-leake.org> (message from Stephen Leake on Sun, 20 Nov 2022 14:09:49 -0800)
> From: Stephen Leake <stephen_leake@stephe-leake.org>
> Cc: João Távora <joaotavora@gmail.com>
> Date: Sun, 20 Nov 2022 14:09:49 -0800
>
> eglot builds a name for a server using the root directory of the
> project - in effect:
>
> (file-name-base (directory-file-name (project-root (project-current))))
>
> That name shows up in the elgot mode line, to tell the user which server
> the buffer is connected to, in progress report messages, and in the name
> of the EGLOT log buffer, which is useful for debugging things.
>
> If the project root directory happens to have a meaningful name, that's
> fine. In my use cases, it's usually not meaningful.
So Eglot should allow customization of what is shown on the mode line.
> So I'd like to add a new cl-defgeneric to project.el:
>
> (cl-defgeneric project-name (project)
> "A human-readable name for the project."
> (file-name-base (directory-file-name (project-root project))))
>
> Then I can override that in my projects, and eglot will use my desired
> name.
I don't see why the needs of Eglot usage justify another generic in
project.el, or should be solved in project.el to begin with. If Dmitry
wants to add such a generic for his own reasons, with some future
development of project.el in mind, I won't object, of course. Otherwise, it
sounds like the wrong way of solving specific problems: by generalizing the
heck out of them. E.g., tomorrow we decide that Eglot shouldn't use the
project name on the mode line, and puff! your solution evaporates.
next prev parent reply other threads:[~2022-11-21 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 22:09 Add cl-defgeneric project-name; first use case eglot Stephen Leake
2022-11-20 22:14 ` [SPAM UNSURE] " Stephen Leake
2022-11-21 0:37 ` Stephen Leake
2022-11-21 13:07 ` Eli Zaretskii [this message]
2022-11-21 13:50 ` João Távora
2022-11-21 14:17 ` Eli Zaretskii
2022-11-21 21:29 ` João Távora
2022-11-22 9:56 ` Kévin Le Gouguec
2022-11-23 2:34 ` Dmitry Gutov
2022-11-23 8:33 ` Juri Linkov
2022-11-23 13:46 ` Dmitry Gutov
2022-11-27 18:47 ` Kévin Le Gouguec
2022-11-28 1:21 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a64k4fru.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).