From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470) Date: Sat, 20 Jan 2024 12:17:06 +0200 Message-ID: <83a5p0til9.fsf@gnu.org> References: <170030013667.20571.18090141972402319489@vcs2.savannah.gnu.org> <20231118093537.9F147C0C994@vcs2.savannah.gnu.org> <87a5p1679r.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, rahguzar@zohomail.eu To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 20 11:18:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rR8Qt-0004lG-SU for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Jan 2024 11:18:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rR8Q2-000636-3n; Sat, 20 Jan 2024 05:17:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR8Pw-00062d-40 for emacs-devel@gnu.org; Sat, 20 Jan 2024 05:17:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR8Pt-0001s0-Jt; Sat, 20 Jan 2024 05:17:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z/FJhBuGzwJz0DGDCEvgsiCT9ienm9WsVA9FOjp+VXo=; b=MRFwJQekEi3d 7QCYGs+v19E3QeSotW058QETVhSrs1S/W4xSuWrkrnYMyewELVdxzs/6k+tc9AESnLS1bUPvf1MDR PMPwU7R8GvphNyWAyUH17rcaxhFIvkSMl4QgIVh24F8eDf3oYbESeiv+2hkgCaTTCac6s7aRKGxT9 dGpkuXXgZDSbFfzsAnnlbXHp3c7Cr0LNiSJi/VhhOPgj7TPJzu+j8ulsl+uCIMow0qc/VCS7nT8G+ 01NWyp/yDMRsnpKF2jSwx6KonKMTGEEXP7DzvUXJRNvzeEyUT7CUVYmfMPztbSOfg2M1DrLGImhk/ iWfcGK+IjoY43MsrGhO54w==; In-Reply-To: <87a5p1679r.fsf@gmx.de> (message from Michael Albinus on Fri, 19 Jan 2024 09:45:36 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315137 Archived-At: > From: Michael Albinus > Cc: Rahguzar > Date: Fri, 19 Jan 2024 09:45:36 +0100 > > Eli Zaretskii writes: > > > branch: master > > commit 84e4bc6219af2c08097027d4b75043b23c1fcce6 > > Author: Rahguzar > > Commit: Eli Zaretskii > > > > Add input methods for Urdu, Pashto and Sindhi (bug#66470) > > This commit has added the following error in Emacs' tests: > > --8<---------------cut here---------------start------------->8--- > # make -C test test-custom-deps > The following load problems appeared: > (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan)) > (quail pakistan (file-missing Cannot open load file No such file or directory pakistan)) > Test test-custom-deps backtrace: > signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus > ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro > (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f > (let (form-description-6) (if (not (unwind-protect (setq value-5 cus > (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form- > (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name test-custom-deps :documentation nil : > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil > ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) > ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco > eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n > command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el" > command-line() > normal-top-level() > Test test-custom-deps condition: > (ert-test-failed > ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value > ((pakistan-urdu-input pakistan > (file-missing "Cannot open load file" > "No such file or directory" > "pakistan")) > (quail pakistan > (file-missing "Cannot open load file" > "No such file or directory" "pakistan"))))) > FAILED 1/1 test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35 > > Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec) > > 1 unexpected results: > FAILED test-custom-deps > --8<---------------cut here---------------end--------------->8--- I tried to look into this. It seems test-custom-deps runs cus-test-deps and then requires that cus-test-deps-errors is nil. I therefore ran cus-test-deps interactively, and looked at cus-test-deps-errors. It is not nil, but its value is ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J (file-missing "Cannot open load file" "No such file or directory" "ob-J"))) which doesn't mention pakistan at all. So I'm unsure how to proceed. It would be useful to see the value of cus-test-deps-errors in the test that fails, or maybe I'm missing something in how this test should be run interactively. P.S. My guess is that some autoload is missing from pakistan.el, but without reproducing the problem I cannot verify that and cannot test a solution, and the error message from the failing test is not helpful, as it doesn't divulge the important details.