From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: md5 broken? Date: Sat, 28 May 2011 22:35:41 +0300 Message-ID: <838vtqbotu.fsf@gnu.org> References: <87ipsv188f.fsf@gmail.com> <87zkm7t3n4.fsf@rho.meyering.net> <83hb8fasyb.fsf@gnu.org> <87lixrt0fx.fsf@rho.meyering.net> <83fwnyc3v1.fsf@gnu.org> <4DE11E56.9040506@cs.ucla.edu> <83d3j2bw9g.fsf@gnu.org> <4DE14913.9080507@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1306611358 11397 80.91.229.12 (28 May 2011 19:35:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 May 2011 19:35:58 +0000 (UTC) Cc: emacs-devel@gnu.org, jim@meyering.net, antoine.levitt@gmail.com To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 28 21:35:54 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QQPIg-0008U2-6S for ged-emacs-devel@m.gmane.org; Sat, 28 May 2011 21:35:54 +0200 Original-Received: from localhost ([::1]:41845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQPIf-000526-Ho for ged-emacs-devel@m.gmane.org; Sat, 28 May 2011 15:35:53 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQPIU-0004eK-3W for emacs-devel@gnu.org; Sat, 28 May 2011 15:35:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQPIT-0003K8-2h for emacs-devel@gnu.org; Sat, 28 May 2011 15:35:42 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:38814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQPIS-0003K4-Sa for emacs-devel@gnu.org; Sat, 28 May 2011 15:35:41 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LLX008007OFX600@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sat, 28 May 2011 22:35:39 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.221.158]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LLX008ON7RB2CA0@a-mtaout22.012.net.il>; Sat, 28 May 2011 22:35:39 +0300 (IDT) In-reply-to: <4DE14913.9080507@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139848 Archived-At: > Date: Sat, 28 May 2011 12:12:19 -0700 > From: Paul Eggert > CC: jim@meyering.net, antoine.levitt@gmail.com, emacs-devel@gnu.org > > On 05/28/11 09:55, Eli Zaretskii wrote: > > "Builds" is not enough. We also want to assure that every compiler > > that supports inline functions really sees the inline keyword there. > > No, "#define inline /* empty */" is a perfectly adequate workaround. Not if wed want the result be a decent binary with reasonable performance. See bidi.c, for example. > >> > so it does appear that it works with all supported builds. > > There's also the Windows build, which still supports non-GCC > > compilers. > > Evidently it's not a significant problem with Windows, since it's been > in use for over a month without complaint. Yeah, and guess who took care of that. But you are missing the point. I'm saying that we should have only one of "INLINE" and "inline", not both. I don't care much which one; I only mentioned the former because it is used widely in Emacs and for a long time. Is there any reasons to keep both?