From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 'struct window' cleanup #3 Date: Wed, 27 Jun 2012 22:36:33 +0300 Message-ID: <838vf88s3i.fsf@gnu.org> References: <4FE827B6.6020306@yandex.ru> <4FE89369.2000708@gmx.at> <4FE896A9.3090002@yandex.ru> <4FE9643C.1090201@gmx.at> <83a9zq9jhp.fsf@gnu.org> <83lij98nhj.fsf@gnu.org> <4FEAB1EA.3000307@yandex.ru> <83ehp08y8f.fsf@gnu.org> <4FEB4A1E.5060203@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1340825793 3325 80.91.229.3 (27 Jun 2012 19:36:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 27 Jun 2012 19:36:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 27 21:36:32 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sjy2M-0003P3-FD for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2012 21:36:26 +0200 Original-Received: from localhost ([::1]:42416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjy2M-0007de-Ef for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2012 15:36:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjy2J-0007dY-MT for emacs-devel@gnu.org; Wed, 27 Jun 2012 15:36:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sjy2H-0005d9-Sr for emacs-devel@gnu.org; Wed, 27 Jun 2012 15:36:23 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:55081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjy2H-0005cq-KL for emacs-devel@gnu.org; Wed, 27 Jun 2012 15:36:21 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M6A00500JSJN200@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Wed, 27 Jun 2012 22:36:19 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M6A005M3JSJMK20@a-mtaout21.012.net.il>; Wed, 27 Jun 2012 22:36:19 +0300 (IDT) In-reply-to: <4FEB4A1E.5060203@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151234 Archived-At: > Date: Wed, 27 Jun 2012 21:59:58 +0400 > From: Dmitry Antipov > CC: emacs-devel@gnu.org > > I would like to propose alternate redesign for this: init_window_once > sets Vframe_list to Qnil. After calling make_initial_frame, Vframe_list > becomes non-nil, so !NILP (Vframe_list) means init_window_once was > passed. How is this better than the current use of window_initialized? At least that flag is clearly meant to indicate that window.c has been initialized. By contrast, if we use the fact that Vframe_list is initialized in make_initial_frame that is called by init_window_once, we are piggy-backing a mechanism that was never meant to be such an indication.