From: Eli Zaretskii <eliz@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guile-user@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCH 1/3] Support Guile backtraces in compilation mode.
Date: Fri, 08 Aug 2014 16:47:46 +0300 [thread overview]
Message-ID: <838umzm6t9.fsf@gnu.org> (raw)
In-Reply-To: <1407495956-20322-2-git-send-email-janneke@gnu.org>
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Fri, 8 Aug 2014 13:05:54 +0200
>
> +(defcustom compilation-guile-load-path '("/usr/share/guile/2.0" "/usr/share/guile/site")
Not a good idea, IMO. This is inherently system-dependent, and
doesn't support Guile installations with non-default $(prefix). IOW,
it's unreliable.
How about invoking the Guile executable and asking it to emit the
path? That would be reliable and portable.
> + "Path to locate Guile soure files for incomplete (Guile %load-path based) error messages. If compilation-guile-load-path-p is non-nil, it is dynamically set from Guile."
Please break the doc string into lines that are shorter than 75
columns, that's our coding practice.
Thanks.
next prev parent reply other threads:[~2014-08-08 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 11:05 compilation-mode support for Guile backtrace Jan Nieuwenhuizen
2014-08-08 11:05 ` [PATCH 1/3] Support Guile backtraces in compilation mode Jan Nieuwenhuizen
2014-08-08 13:29 ` Stefan Monnier
2014-08-08 17:43 ` Jan Nieuwenhuizen
2014-08-08 13:47 ` Eli Zaretskii [this message]
2014-08-08 13:53 ` Jan Nieuwenhuizen
2014-08-08 13:57 ` Eli Zaretskii
2014-08-08 14:34 ` Emilio Lopes
2014-08-08 11:05 ` [PATCH 2/3] Add Guile backtrace example Jan Nieuwenhuizen
2014-08-08 11:05 ` [PATCH 3/3] Add tests for Guile compile regexps Jan Nieuwenhuizen
2014-08-08 13:33 ` compilation-mode support for Guile backtrace Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838umzm6t9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=guile-user@gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).