From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] CONTRIBUTE - writing tests for understanding internals Date: Thu, 12 Nov 2015 05:40:51 +0200 Message-ID: <838u63khq4.fsf@gnu.org> References: <87twotqxme.fsf@cumego.com> <83a8qlky1c.fsf@gnu.org> <874mgtgess.fsf@cumego.com> <834mgslf34.fsf@gnu.org> <5643AE61.1070503@cumego.com> <83egfwjki8.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1447299711 24767 80.91.229.3 (12 Nov 2015 03:41:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Nov 2015 03:41:51 +0000 (UTC) Cc: esperanto@cumego.com, emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 12 04:41:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZwilZ-0003wr-UU for ged-emacs-devel@m.gmane.org; Thu, 12 Nov 2015 04:41:42 +0100 Original-Received: from localhost ([::1]:44239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwilY-0003kV-UD for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 22:41:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwil6-0003if-PC for emacs-devel@gnu.org; Wed, 11 Nov 2015 22:41:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwil2-0003SW-OT for emacs-devel@gnu.org; Wed, 11 Nov 2015 22:41:12 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:64755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwil2-0003Rm-GU for emacs-devel@gnu.org; Wed, 11 Nov 2015 22:41:08 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NXO00800N2OLA00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Thu, 12 Nov 2015 05:41:06 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXO008OONKIH940@a-mtaout20.012.net.il>; Thu, 12 Nov 2015 05:41:06 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194192 Archived-At: > From: John Wiegley > Cc: Przemys=C5=82aw Wojnowski , > emacs-devel@gnu.org > Date: Wed, 11 Nov 2015 13:36:19 -0800 >=20 > Rather than agreeing or disagreeing, let's say that there is value = here, we > just don't who it will attract and why. I'm OK with encouraging peo= ple to > write tests. Anything that invites them to participate more cannot = really > hurt, can it? Of course. But we already have that, thanks to a recent change by Karl: ** Test your changes. Please test your changes before committing them or sending them to = the list. If possible, add a new test along with any bug fix or new functionality you commit (of course, some changes cannot be easily tested). Emacs uses ERT, Emacs Lisp Regression Testing, for testing. See (i= nfo "(ert)") or https://www.gnu.org/software/emacs/manual/html_node/ert= / for more information on writing and running tests.