From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library Date: Wed, 25 Nov 2015 19:27:28 +0200 Message-ID: <838u5mxa4f.fsf@gnu.org> References: <20151124203604.2994.60394@vcs.savannah.gnu.org> <83a8q2ycon.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448472480 22996 80.91.229.3 (25 Nov 2015 17:28:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2015 17:28:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 25 18:27:49 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1drA-0004AY-Qi for ged-emacs-devel@m.gmane.org; Wed, 25 Nov 2015 18:27:48 +0100 Original-Received: from localhost ([::1]:46823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1drC-0007iQ-GR for ged-emacs-devel@m.gmane.org; Wed, 25 Nov 2015 12:27:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dqz-0007h6-Ui for emacs-devel@gnu.org; Wed, 25 Nov 2015 12:27:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dqv-0001O5-0y for emacs-devel@gnu.org; Wed, 25 Nov 2015 12:27:37 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:34515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dqu-0001Nz-Pm for emacs-devel@gnu.org; Wed, 25 Nov 2015 12:27:32 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NYD00A00S0WA600@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Wed, 25 Nov 2015 19:27:31 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYD00AECSHV8350@a-mtaout23.012.net.il>; Wed, 25 Nov 2015 19:27:31 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195228 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Tue, 24 Nov 2015 23:01:08 -0500 > > >> Hmm... maybe we should even push this let-binding directly into > >> locate-file-completion-table. > >> WDYT? > > Even if suffixes are nil? > > But if you say so, I don't object; I admit I don't fully understand > > that function. > > I'm not 100% sure the let-binding is always going to be better when > suffixes is empty, but it's probably no worse. OK, I will do this on master once the change is merged from emacs-25.