From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: tags-loop-continue Date: Thu, 14 Jan 2016 18:00:03 +0200 Message-ID: <838u3si22k.fsf@gnu.org> References: <83wprimto9.fsf@gnu.org> <56916C10.6050004@yandex.ru> <83oacumqmj.fsf@gnu.org> <56917246.1010800@yandex.ru> <5691795E.9010008@yandex.ru> <83lh7ym725.fsf@gnu.org> <5691D768.3020908@yandex.ru> <83bn8tmnvq.fsf@gnu.org> <56928356.2000609@yandex.ru> <8360z1mkfc.fsf@gnu.org> <5696EE9D.2090708@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452787226 6807 80.91.229.3 (14 Jan 2016 16:00:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Jan 2016 16:00:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 14 17:00:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJkJq-0006mm-UL for ged-emacs-devel@m.gmane.org; Thu, 14 Jan 2016 17:00:15 +0100 Original-Received: from localhost ([::1]:43501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJkJq-00070Q-5r for ged-emacs-devel@m.gmane.org; Thu, 14 Jan 2016 11:00:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJkJV-0006uo-RN for emacs-devel@gnu.org; Thu, 14 Jan 2016 10:59:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJkJR-00056S-3H for emacs-devel@gnu.org; Thu, 14 Jan 2016 10:59:53 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJkJQ-00056O-W3; Thu, 14 Jan 2016 10:59:49 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3255 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aJkJQ-0001AV-8K; Thu, 14 Jan 2016 10:59:48 -0500 In-reply-to: <5696EE9D.2090708@yandex.ru> (message from Dmitry Gutov on Thu, 14 Jan 2016 03:41:01 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198130 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Thu, 14 Jan 2016 03:41:01 +0300 > > On 01/10/2016 08:08 PM, Eli Zaretskii wrote: > > >> Because tags-query-replace uses a special keymap, we can bind > >> tags-loop-continue to M-, in it. _Maybe_ we can similarly use a new > >> keymap during tags-search's execution. > >> > >> If you think it's a good idea, I can look into it. > > > > I think it should be okay, thanks. As long as the command is > > interactive, it can always be rebound, if users so want. > > Sorry, this is a bust. The way tags-loop-continue is used, to continue > execution after a user pressed C-g to quit tags-query-replace, makes it > not suitable for a binding inside query-replace-map. Too bad. Thanks for trying. > So, I propose two options: > > - Un-obsolete the command, but keep it without binding (now done in > emacs-25). Since it's not used too often, no binding makes some sense, > and users can choose their own bindings. > > - Also bind it to M-*. Pro: users will have something to press right > away. Cons: the change in binding is still confusing, and hopefully > we'll reimplement all these workflows in a different ways soon, thus > making tags-loop-continue binding even less necessary. Unfortunately, I think it makes much more sense to bind tags-loop-continue back to 'M-,', and bind xref-pop-marker-stack to 'M-*', the old binding of pop-tag-mark, which xref-pop-marker-stack replaces. When tags-loop-continue is no longer needed, we could use its binding for xref-pop-marker-stack, but until then we cannot use its key for an entirely different command, I think.