From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Character literals for Unicode (control) characters Date: Sun, 06 Mar 2016 17:54:18 +0200 Message-ID: <838u1vwqj9.fsf@gnu.org> References: <87r3fsjenn.fsf@gnus.org> <56D8623F.6060806@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1457279683 9102 80.91.229.3 (6 Mar 2016 15:54:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Mar 2016 15:54:43 +0000 (UTC) Cc: larsi@gnus.org, johnw@gnu.org, emacs-devel@gnu.org, eggert@cs.ucla.edu To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 06 16:54:38 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1acb0v-0001aw-S4 for ged-emacs-devel@m.gmane.org; Sun, 06 Mar 2016 16:54:37 +0100 Original-Received: from localhost ([::1]:50996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acb0v-0008HV-9m for ged-emacs-devel@m.gmane.org; Sun, 06 Mar 2016 10:54:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acb0h-0008HQ-Jl for emacs-devel@gnu.org; Sun, 06 Mar 2016 10:54:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acb0g-0003qZ-NU for emacs-devel@gnu.org; Sun, 06 Mar 2016 10:54:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acb0b-0003ne-6n; Sun, 06 Mar 2016 10:54:17 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3226 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1acb0a-0002mS-2v; Sun, 06 Mar 2016 10:54:16 -0500 In-reply-to: (message from Philipp Stephani on Sun, 06 Mar 2016 15:24:47 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200996 Archived-At: > From: Philipp Stephani > Date: Sun, 06 Mar 2016 15:24:47 +0000 > > I've attached a patch with an initial implementation. Thanks. > +/* Hash table that maps Unicode character names to code points. */ > +static Lisp_Object character_names; > + > +/* Length of the longest Unicode character name, in bytes. */ > +static ptrdiff_t max_character_name_length; > + > +/* Initializes `character_names' and `max_character_name_length'. > + Called by `read_escape'. */ I wonder if there's a better way, in particular with a smaller memory footprint. Doesn't map-char-table work well enough to avoid generating all the names up front? > + if (! RANGED_INTEGERP (0, code, 0x10FFFF)) This should use MAX_UNICODE_CHAR.