unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Göktuğ Kayaalp" <self@gkayaalp.com>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: [PATCH] Enable customisation for electric-quote-mode chars
Date: Mon, 29 Aug 2016 19:39:32 +0300	[thread overview]
Message-ID: <838tvfbkcb.fsf@gnu.org> (raw)
In-Reply-To: <874m631qwx.fsf@xi.bootis> (message from Göktuğ Kayaalp on Mon, 29 Aug 2016 19:27:42 +0300)

> From: Göktuğ Kayaalp <self@gkayaalp.com>
> Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
> Date: Mon, 29 Aug 2016 19:27:42 +0300
> 
> > From: Eli Zaretskii <eliz@gnu.org>
> > Date: 2016-08-29 06:08:25 PM +0300
> > Eli Zaretskii wrote:
> >> From: Göktuğ Kayaalp <self@gkayaalp.com>
> >> Cc: eliz@gnu.org, emacs-devel@gnu.org
> >> Date: Mon, 29 Aug 2016 08:28:19 +0300
> 
> (I'm sorry for /borrowing/ your citation style, but it's very nice, I
> couldn't refuse.  Hope that doesn't annoy you :)  I've made it a bit
> different though.)

It's not me, it's Rmail that's doing this.  (No, I'm not annoyed, of
course not.)

> >> +quote characters.  It's possible to change the default quotes listed
> >> +above, by customizing the variable @code{electric-quote-chars}, a list
> >> +of four characters, where the items correspond to the left single
> >> +quote, the right single quote, the left double quote and the right
> >> +double quote, respectively, whose default value is
> >> +@code{'(?‘ ?’ ?“ ?”)}.
> >
> > There's no need to go to such detail when describing a customizable
> > option.  The Customize interface should be enough for the user to
> > figure out what to do.
> 
> Then I can remove the part after reference to the variable name, and
> improve the defcustom's documentation (see below).  Is that okay?

Yes.

> >   Default (‘..’ “..”)
> >   Arabic (".." ”..“)
> >   German  (‚..‛ „..“)
> >   French (‹..› «..»)
> >   Cyrillic (‚..‘ «..»)
> >
> > etc.  WDYT?  (See https://en.wikipedia.org/wiki/Quotation_mark for
> > some more.)
> 
> Well I think we'd rather not do that but improve the docstring instead,
> because, looking at the big summary table on the page you linked [1]
> there's not only a lot of variance among languages, but some of them
> have multiple standard and alternative forms, and some don't have single
> quotes (e.g. Persian).  I think we'd better keep the defaults and
> improve the documentation, and not have implement all the languages nor
> have to pick a subset.

If no one else thinks my suggestion is a significant improvement, I
won't insist.  (And of course, we don't need to implement the entire
Wikipedia list, I'm not even sure it's accurate.)

It could be enough to mention some of the possibilities in the doc
string, together with their cultural affiliations.

> Maybe we could leave setting these variables to the language environment
> if that's possible?

I think it's too early for that, we haven't yet figured out how to set
up language dependent settings.  One problem with the idea you raise
is that a user can reside in a certain locale, but use universal
settings commonly used in multilingual environments.

> Please direct me on how to proceed, and I'll update the patch as soon as
> I can

I would suggest to wait for a couple of days for more comments.  If no
one supports my suggestions about language-tagged alternatives, you
can disregard them, and only make the documentation changes already
mentioned.

Thanks.



  reply	other threads:[~2016-08-29 16:39 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27 14:22 [PATCH] Enable customisation for electric-quote-mode chars Göktuğ Kayaalp
2016-08-27 14:38 ` Eli Zaretskii
2016-08-27 15:23   ` Göktuğ Kayaalp
2016-08-27 19:16     ` Paul Eggert
2016-08-28  1:00       ` Göktuğ Kayaalp
2016-08-29  1:55         ` Paul Eggert
2016-08-29  5:28           ` Göktuğ Kayaalp
2016-08-29  6:14             ` Paul Eggert
2016-10-05 18:53               ` Göktuğ Kayaalp
2016-10-05 19:06                 ` Paul Eggert
2016-10-06  6:40                   ` Eli Zaretskii
2016-10-06 21:31                     ` Paul Eggert
2016-10-07 18:33                       ` Göktuğ Kayaalp
2016-10-10  3:57                         ` Paul Eggert
2016-10-13 18:28                           ` Göktuğ Kayaalp
2016-10-13 18:35                             ` Paul Eggert
2016-10-22 14:00                               ` Göktuğ Kayaalp
2016-10-23 10:25                                 ` Paul Eggert
2016-10-23 15:09                                   ` Göktuğ Kayaalp
2016-10-27 15:12                                     ` Paul Eggert
2016-10-27 17:21                                       ` Göktuğ Kayaalp
2016-08-29 15:08             ` Eli Zaretskii
2016-08-29 15:54               ` Yuri Khan
2016-08-29 16:23                 ` Eli Zaretskii
2016-08-29 16:27               ` Göktuğ Kayaalp
2016-08-29 16:39                 ` Eli Zaretskii [this message]
2016-08-29 17:19                   ` Göktuğ Kayaalp
2016-08-29 17:30                 ` Paul Eggert
2016-08-29 17:44                   ` Eli Zaretskii
2016-08-29 18:43                     ` Paul Eggert
2016-08-29 19:30                       ` Eli Zaretskii
2016-08-30 17:38                         ` Paul Eggert
2016-08-30 17:49                           ` Eli Zaretskii
2016-08-31 11:08                             ` Richard Stallman
2016-09-01 18:56                         ` Göktuğ Kayaalp
2016-09-01 19:15                           ` Paul Eggert
2016-09-01 21:13                             ` Göktuğ Kayaalp
2016-09-01 21:30                               ` Paul Eggert
2016-09-02  5:06                                 ` Yuri Khan
2016-09-02  7:30                                   ` Eli Zaretskii
2016-09-02 10:37                                     ` Yuri Khan
2016-09-02 13:24                                       ` Göktuğ Kayaalp
2016-08-29 16:15           ` tarball builds (was: [PATCH] Enable customisation for electric-quote-mode chars) Stefan Monnier
2016-08-30 15:14             ` Eli Zaretskii
2016-08-30 15:53               ` tarball builds Stefan Monnier
2016-08-30 15:59             ` Paul Eggert
2016-08-30 17:00               ` Stefan Monnier
2016-08-30 17:58                 ` Paul Eggert
2016-08-29  2:33         ` [PATCH] Enable customisation for electric-quote-mode chars Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838tvfbkcb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=self@gkayaalp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).