From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Standard check before creating large num of frames
Date: Thu, 15 Sep 2016 17:58:18 +0300 [thread overview]
Message-ID: <838tut6whh.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1609151513030.25124@calancha-pc> (message from Tino Calancha on Thu, 15 Sep 2016 15:26:43 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Thu, 15 Sep 2016 15:26:43 +0900 (JST)
> Cc: tino.calancha@gmail.com
>
> several functions might create new frames. In particular when
> `pop-up-frames' is non-nil, `display-buffer' creates a new frame.
> Creating a lot of new frames might be expensive.
>
> Some functions may ask for user confirmation before creating an
> many frames.
> For instance, see `ibuffer-do-view-1': this function ask for confirmation
> before creating > 3 frames.
> IMO, it's good if each function creating a large number of frames
> do a similar check.
> We might add a new option, for instance 'max-number-of-frames'
> or 'frame-max-number':
>
> (defcustom max-number-of-frames 3
> "Maximum number of frames to create before asking user confirmation."
> :version "25.2"
> :type 'integer
> :group 'convenience)
FWIW, I don't like nagging users like that. It could be an optional
feature, off by default, I guess. Did you really hear from someone
complaining about too many frames open without their consent?
A couple of minor comments:
> (defun frame-create-many-frames-p (nframes &optional prompt)
> "Return non-nil if it's OK to create NFRAMES.
> If NFRAMES + current number of frames is > `max-number-of-frames',
> ask for user confirmation.
> An optional arg is the prompt to ask the user."
> (let* ((tot (+ nframes (length (frame-list))))
> (str (or prompt (format "Really create %s frames? " nframes)))
> (res (or (<= tot max-number-of-frames)
> (y-or-n-p str))))
> res))
First, the message text is confusing: when the user asked for creating
a single additional frame, we are asking them
Really create 4 frames?
The user didn't ask for 4 frames, she only asked for one. A better
text would be
You already have 3 frames; really create another one?
In addition, I think you should also allow the user to tell Emacs
never ask this question again in the current session, not just yes/no
for this one frame.
prev parent reply other threads:[~2016-09-15 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 6:26 Standard check before creating large num of frames Tino Calancha
2016-09-15 12:00 ` Stefan Monnier
2016-09-15 15:33 ` Tino Calancha
2016-09-15 14:58 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838tut6whh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).