From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs26: Quick thoughts on display-line-numbers-mode Date: Sun, 08 Oct 2017 10:44:50 +0300 Message-ID: <838tgmt765.fsf@gnu.org> References: <1507229521.6891.6.camel@gmail.com> <83fuaxwgql.fsf@gnu.org> <1507232129.15251.12.camel@gmail.com> <83efqhwezk.fsf@gnu.org> <87fuaxxjog.fsf@gmail.com> <83a814wz3w.fsf@gnu.org> <87h8vad5n8.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507448706 30461 195.159.176.226 (8 Oct 2017 07:45:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 07:45:06 +0000 (UTC) Cc: maplant95@gmail.com, emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 08 09:45:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16Gh-0006zT-Fj for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 09:44:59 +0200 Original-Received: from localhost ([::1]:52811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16Gp-0006e5-1N for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 03:45:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16Gg-0006dz-5O for emacs-devel@gnu.org; Sun, 08 Oct 2017 03:44:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e16Gd-0008WU-2q for emacs-devel@gnu.org; Sun, 08 Oct 2017 03:44:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16Gd-0008WQ-0C; Sun, 08 Oct 2017 03:44:55 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3524 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e16Gc-0008Be-EA; Sun, 08 Oct 2017 03:44:54 -0400 In-reply-to: <87h8vad5n8.fsf@gmail.com> (message from Alex on Sat, 07 Oct 2017 15:12:11 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219238 Archived-At: > From: Alex > Cc: maplant95@gmail.com, emacs-devel@gnu.org > Date: Sat, 07 Oct 2017 15:12:11 -0600 > > > Which other faces are in more than one group? > > Here are some in face.el: > mode-line* > window-divider* > fringe > cursor > mouse > menu Thanks, I'm convinced. > Okay, I've attached a patch which does this. Additionally, I added the > `display-line-numbers' group to the `convenience' group since (n)linum > belong to that group. nlinum belongs to 2 groups already, as do groups > such as `message' and `mode-line-faces', so it should also be fine. "Convenience" is a lousy name for a customization group, as it doesn't really convey any meaning. But I guess that's water under the bridge now. The patch LGTM, please push to the release branch. I would suggest to mention in the log message the URL of the first message in this thread. TIA