unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: maplant95@gmail.com, emacs-devel@gnu.org
Subject: Re: Emacs26: Quick thoughts on display-line-numbers-mode
Date: Sun, 08 Oct 2017 10:44:50 +0300	[thread overview]
Message-ID: <838tgmt765.fsf@gnu.org> (raw)
In-Reply-To: <87h8vad5n8.fsf@gmail.com> (message from Alex on Sat, 07 Oct 2017 15:12:11 -0600)

> From: Alex <agrambot@gmail.com>
> Cc: maplant95@gmail.com,  emacs-devel@gnu.org
> Date: Sat, 07 Oct 2017 15:12:11 -0600
> 
> > Which other faces are in more than one group?
> 
> Here are some in face.el:
> mode-line*
> window-divider*
> fringe
> cursor
> mouse
> menu

Thanks, I'm convinced.

> Okay, I've attached a patch which does this. Additionally, I added the
> `display-line-numbers' group to the `convenience' group since (n)linum
> belong to that group. nlinum belongs to 2 groups already, as do groups
> such as `message' and `mode-line-faces', so it should also be fine.

"Convenience" is a lousy name for a customization group, as it doesn't
really convey any meaning.  But I guess that's water under the bridge
now.

The patch LGTM, please push to the release branch.  I would suggest to
mention in the log message the URL of the first message in this
thread.

TIA



  reply	other threads:[~2017-10-08  7:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 18:38 Emacs26: Quick thoughts on display-line-numbers-mode Robert Weiner
2017-10-05 18:52 ` Matthew Plant
2017-10-05 19:13   ` Eli Zaretskii
     [not found]     ` <1507232129.15251.12.camel@gmail.com>
2017-10-05 19:50       ` Eli Zaretskii
2017-10-05 20:07         ` Matthew Plant
2017-10-05 23:24         ` Alex
2017-10-06  6:48           ` Eli Zaretskii
2017-10-07 21:12             ` Alex
2017-10-08  7:44               ` Eli Zaretskii [this message]
2017-10-09  0:06                 ` Alex
2017-10-05 19:02 ` Eli Zaretskii
2017-10-05 19:44   ` Robert Weiner
2017-10-05 19:58     ` Eli Zaretskii
2017-10-05 21:34       ` Robert Weiner
2017-10-06  3:09       ` Matthew Plant
2017-10-06  7:26         ` Eli Zaretskii
2017-10-06  7:50           ` Matthew Plant
2017-10-06  8:16             ` Eli Zaretskii
2017-10-06 12:37               ` Stefan Monnier
2017-10-06 13:06                 ` Eli Zaretskii
2017-10-06 13:25                   ` John Wiegley
2017-10-06 14:17                     ` Eli Zaretskii
2017-10-06 18:47                       ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838tgmt765.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=agrambot@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=maplant95@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).