From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Blink Cursor mode is off by default Date: Mon, 11 Jun 2018 19:48:51 +0300 Message-ID: <838t7lqnf0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1528735651 18828 195.159.176.226 (11 Jun 2018 16:47:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2018 16:47:31 +0000 (UTC) Cc: Radon Rosborough To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 11 18:47:27 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPyZ-0004pw-DT for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2018 18:47:27 +0200 Original-Received: from localhost ([::1]:50190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSQ0f-0006bT-9x for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2018 12:49:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPzu-0006a8-Jr for emacs-devel@gnu.org; Mon, 11 Jun 2018 12:48:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPzt-0004Vu-SR for emacs-devel@gnu.org; Mon, 11 Jun 2018 12:48:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPzo-0004Sf-8Y; Mon, 11 Jun 2018 12:48:44 -0400 Original-Received: from [176.228.60.248] (port=2182 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSPzn-0005Sc-N2; Mon, 11 Jun 2018 12:48:44 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226229 Archived-At: Commit 2db57579b08ac99c464b6d3698648b3167fc5d55 caused what the Subject says: blink-cursor-mode is now off by default on GUI frames. (I see this on Windows, but I cannot imagine it is any different on other GUI platforms.) (Judging by lack of complaints, perhaps we should just turn that mode off by default ;-) It happened because that commit moved the call to custom-reevaluate-setting to an earlier place during startup, and the initial window-system is not yet set up at that place. So the condition in blink-cursor-mode evaluates to nil, and the mode is disabled. I can see several ways out of this: . Move the call to custom-reevaluate-setting back where it was, and instead call custom-reevaluate-setting in that earlier place only for Info-default-directory-list, which was the original reason why the call was moved; . Add a call to custom-reevaluate-setting for blink-cursor-mode where the window-system is already set up; . Call custom-reevaluate-setting for all the delayed-init variables twice: once where we do that now, and again where we did that before the above commit; . Introduce yet another variable similar to custom-delayed-init-variables, but separate from it, and put on it all the delayed-init variables that need the window-system to be set up, leaving all the rest in custom-delayed-init-variables. I tend to favor the 3rd alternative, as it is relatively easy and at the same time reliable. The first two mean a significant maintenance burden to consider each new variable whether it needs an additional evaluation after window-system setup; the last alternative is maybe too complex. Comments?