From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Increase minimum required GTK versions? Date: Tue, 09 Apr 2019 21:21:55 +0300 Message-ID: <838swj6nuk.fsf@gnu.org> References: <87h8b9tz84.fsf@gmail.com> <83h8b98wg3.fsf@gnu.org> <87d0lxty7f.fsf@gmail.com> <537036b7-549c-0aab-cc06-70c26c683ac7@cs.ucla.edu> <87y34kiloy.fsf@gmail.com> <87o95f141i.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148516"; mail-complaints-to="usenet@blaine.gmane.org" Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 20:23:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDvOl-000cUV-U3 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 20:23:08 +0200 Original-Received: from localhost ([127.0.0.1]:47415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDvOk-0006hp-Ln for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 14:23:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDvOA-0006he-Hf for emacs-devel@gnu.org; Tue, 09 Apr 2019 14:22:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDvO9-000062-GA; Tue, 09 Apr 2019 14:22:29 -0400 Original-Received: from [176.228.60.248] (port=3451 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hDvO6-0007kH-9l; Tue, 09 Apr 2019 14:22:29 -0400 In-reply-to: <87o95f141i.fsf@gmail.com> (message from Alex on Tue, 09 Apr 2019 11:28:41 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235176 Archived-At: > From: Alex > Date: Tue, 09 Apr 2019 11:28:41 -0600 > Cc: Stefan Monnier , emacs-devel@gnu.org > > If there are no objections I'll push the revised patch in a few days. To allow proper review, please make the log message more detailed. In particular, stuff you remove that is not under an explicit GTK version condition should have a minimal explanation for why it is TRT to remove it. (The rationale doesn't have to be in the log message, although it would be nice to have it there; it could be just in the email that accompanies the patch.) Please also tell with which GTK versions did you try building with to verify the correctness of the changes. > Subject: [PATCH] Bump minimum GTK versions to 2.24 and 3.10 Not sure we discussed 3.10 as the minimum GTK3 version, we only talked about 2.x AFAIR. What is the situation with GTK3 versions in the current distributions of GNU/Linux? > -/* True iff GTK's version is at least I.J.K. */ > -#ifndef GTK_CHECK_VERSION > -# ifdef USE_GTK > -# define GTK_CHECK_VERSION(i, j, k) \ > - ((i) \ > - < GTK_MAJOR_VERSION + ((j) \ > - < GTK_MINOR_VERSION + ((k) \ > - <= GTK_MICRO_VERSION))) Is it really a good idea to remove this macro? We'll probably have to reintroduce it right away. Thanks.