From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: epa-file Date: Sat, 18 May 2019 12:13:28 +0300 Message-ID: <838sv49lc7.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="198731"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 11:23:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRvZF-000paN-8n for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 11:23:49 +0200 Original-Received: from localhost ([127.0.0.1]:59777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRvZE-0005df-6L for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 05:23:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRvY2-00058X-Pi for emacs-devel@gnu.org; Sat, 18 May 2019 05:22:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRvPI-0000az-B6; Sat, 18 May 2019 05:13:32 -0400 Original-Received: from [176.228.60.248] (port=4688 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRvPH-0003dx-QN; Sat, 18 May 2019 05:13:32 -0400 In-reply-to: (message from Lars Ingebrigtsen on Sat, 18 May 2019 10:42:28 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236711 Archived-At: > From: Lars Ingebrigtsen > Date: Sat, 18 May 2019 10:42:28 +0200 > > (defun epa-file-decode-and-insert (string file visit beg end replace) > (if (fboundp 'decode-coding-inserted-region) > (save-restriction > (narrow-to-region (point) (point)) > (insert (if enable-multibyte-characters > (string-to-multibyte string) > string)) > (decode-coding-inserted-region > (point-min) (point-max) > (substring file 0 (string-match epa-file-name-regexp file)) > visit beg end replace)) > (insert (epa-file--decode-coding-string string (or coding-system-for-read > 'undecided))))) > > Isn't that check for `enable-multibyte-characters' and > call to `string-to-multibyte' completely superfluous? Yes, I think 'insert' already does that internally.