From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Extend gdb to filter registers Date: Sun, 06 Oct 2019 20:36:23 +0300 Message-ID: <838spx3hew.fsf@gnu.org> References: <837e5j6561.fsf@gnu.org> <048A4D6D-54A6-4495-807A-9C123B4AFB7F@gmail.com> <83d0fb47uh.fsf@gnu.org> <633E2F0B-BFD6-4CF1-B9AB-9CD36827ABC1@gmail.com> <83sgo72f0i.fsf@gnu.org> <253E46C6-9141-492C-918E-7218172BA9FC@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255288"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 06 19:36:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHASZ-0014CP-GX for ged-emacs-devel@m.gmane.org; Sun, 06 Oct 2019 19:36:43 +0200 Original-Received: from localhost ([::1]:36050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHASY-0005Cv-A7 for ged-emacs-devel@m.gmane.org; Sun, 06 Oct 2019 13:36:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39204) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHASR-0005Cd-P7 for emacs-devel@gnu.org; Sun, 06 Oct 2019 13:36:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iHASR-0001Eb-H2; Sun, 06 Oct 2019 13:36:35 -0400 Original-Received: from [176.228.60.248] (port=2005 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iHASQ-0005SB-HI; Sun, 06 Oct 2019 13:36:35 -0400 In-reply-to: <253E46C6-9141-492C-918E-7218172BA9FC@gmail.com> (message from Yuan Fu on Sun, 6 Oct 2019 00:24:26 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240652 Archived-At: > From: Yuan Fu > Date: Sun, 6 Oct 2019 00:24:26 -0400 > Cc: Stefan Monnier , > emacs-devel@gnu.org > > * If I found a problem in existing code that is unrelated to my new > feature but is quite trivial to fix (2~3 lines), should I create a > new branch and send it as an separate patch to bug tracker, or > include it in my new feature? It should be a separate patch, yes. Whether to make a separate branch for it is entirely up to you. > * IIUC, I send the patch to the bug tracker and people will review it, > is that correct? Yes. use "M-x report-emacs-bug RET" for that. > * If the patch is a fix, should I first create a bug report and reply > to that report? You can include the patch in the original message you send with report-emacs-bug, and that will create a bug for you. > I'm still not quite sure how everything works, hope I'm not too > garrulous. No sweat. CONTRIBUTE should have some answers for your questions. > Attached is the patch for the bug fix. Changes are: I will review it soon if no one beats me to it. Thanks.