From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Omitting :group    [was: master 7936c8a: * lisp/mb-depth.el
 (minibuffer-depth-indicator): New face.]
Date: Thu, 07 Jan 2021 17:54:38 +0200
Message-ID: <838s94lp35.fsf@gnu.org>
References: <86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="20067"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: gabriel376@hotmail.com, emacs-devel@gnu.org, juri@linkov.net
To: Drew Adams <drew.adams@oracle.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 07 16:55:56 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kxXdk-00058T-0G
	for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 16:55:56 +0100
Original-Received: from localhost ([::1]:43056 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kxXdj-00031j-3Q
	for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 10:55:55 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52390)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kxXcZ-00022q-Q3
 for emacs-devel@gnu.org; Thu, 07 Jan 2021 10:54:44 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58485)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kxXcX-00047i-9F; Thu, 07 Jan 2021 10:54:41 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1068
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kxXcU-0002rK-LW; Thu, 07 Jan 2021 10:54:41 -0500
In-Reply-To: <86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default> (message from Drew
 Adams on Thu, 7 Jan 2021 15:41:28 +0000 (UTC))
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:262690
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/262690>

> Date: Thu, 7 Jan 2021 15:41:28 +0000 (UTC)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: Juri Linkov <juri@linkov.net>, emacs-devel@gnu.org
> 
> > This change causes a byte-compilation warning:
> >   In toplevel form:
> >   mb-depth.el:38:1: Warning: defface for
> >   `minibuffer-depth-indicator' fails to specify
> >   containing group
> 
> IMHO, we should adopt and promote a guideline
> that it's a good, not a bad, idea to always
> include an explicit `:group'.

Aren't you confusing :group in defcustom with :group in defface?