From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 breaks make check Date: Sat, 16 Jan 2021 10:42:40 +0200 Message-ID: <838s8t9ssf.fsf@gnu.org> References: <5a359bd86b4af0378ed63f12670fd355@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25173"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jared@finder.org, emacs-devel@gnu.org To: Aaron Jensen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 16 09:43:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0hBA-0006RH-4E for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Jan 2021 09:43:28 +0100 Original-Received: from localhost ([::1]:46672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0hB9-0004g0-6P for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Jan 2021 03:43:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0hAW-0004Ez-R2 for emacs-devel@gnu.org; Sat, 16 Jan 2021 03:42:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50999) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0hAW-0005Cq-DM; Sat, 16 Jan 2021 03:42:48 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0hAP-0004Lb-FX; Sat, 16 Jan 2021 03:42:44 -0500 In-Reply-To: (message from Aaron Jensen on Sat, 16 Jan 2021 00:38:37 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263094 Archived-At: > From: Aaron Jensen > Date: Sat, 16 Jan 2021 00:38:37 -0600 > Cc: emacs-devel@gnu.org > > (ert-deftest xdisp-tests--window-text-pixel-size () ;; bug#45748 > (with-current-buffer-window "*test*" 'display-buffer-same-window nil > (erase-buffer) > (insert "xxx") > (let* ((char-width (frame-char-width)) > (size (window-text-pixel-size (get-buffer-window) t t))) > (should (equal (/ (car size) char-width) 3))))) > > Eli mentioned moving the tests to manual/redisplay-testsuite.el, which is fine. > > If anyone else has an idea how to make this test work in batch mode, > I'm all ears. This works for me, both interactively and in batch: (ert-deftest xdisp-tests--window-text-pixel-size () (with-current-buffer (generate-new-buffer "*test*") (erase-buffer) (insert "xxx") (switch-to-buffer (current-buffer)) (let* ((char-width (frame-char-width)) (size (window-text-pixel-size nil t t))) (should (equal (/ (car size) char-width) 3)))))