From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: modus-themes ELPA and etc/themes Date: Sat, 27 Mar 2021 09:05:45 +0300 Message-ID: <838s69p1vq.fsf@gnu.org> References: <8335wpd166.fsf@gnu.org> <83zgyxavxi.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 27 07:07:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQ26i-0001a9-56 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Mar 2021 07:07:36 +0100 Original-Received: from localhost ([::1]:47600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQ26h-0001os-13 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Mar 2021 02:07:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQ24t-0000aW-TD for emacs-devel@gnu.org; Sat, 27 Mar 2021 02:05:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59225) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQ24t-00024z-80; Sat, 27 Mar 2021 02:05:43 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3275 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lQ24q-0000kL-P9; Sat, 27 Mar 2021 02:05:42 -0400 In-Reply-To: (message from Stefan Monnier on Fri, 26 Mar 2021 17:41:34 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267095 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Fri, 26 Mar 2021 17:41:34 -0400 > > > I envision that more themes will go the way of modus-themes (and at > > the time you more or less said the same), so I think it would be good > > to design and implement support for such themes in package.el now, > > that we have a real-life example. > > I'm not sure what extra support for it you want in `package.el`. > `package.el` already works great to install modus-themes as well as > many other themes available from ELPA. > > The problem here is with the themes we bundle with Emacs, because these > are not installed in the normal way (e.g. they're not `load-path` and > they're not scrubbed by autoload.el). They are in custom-theme-load-path, right? So that's what I meant by supporting themes in package.el: teach it about custom-theme-load-path, so it could know which themes are bundled. > > I'd like to keep themes in their current location. Where this > > requires additional infrastructure for themes that do something > > special, I think we should add such an infrastructure. > > The current problem is not due to modus-themes doing something special, > but to the need to record the version of modus-themes that we bundle so > that we can compare it to the versions available from ELPA. The problem > already existed for other themes, such as `leuven` which we bundle > without telling package.el. > > I opened a bug for that. Thanks.