unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: modus-themes ELPA and etc/themes
Date: Sat, 27 Mar 2021 09:05:45 +0300	[thread overview]
Message-ID: <838s69p1vq.fsf@gnu.org> (raw)
In-Reply-To: <jwvh7kx1uyl.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 26 Mar 2021 17:41:34 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Fri, 26 Mar 2021 17:41:34 -0400
> 
> > I envision that more themes will go the way of modus-themes (and at
> > the time you more or less said the same), so I think it would be good
> > to design and implement support for such themes in package.el now,
> > that we have a real-life example.
> 
> I'm not sure what extra support for it you want in `package.el`.
> `package.el` already works great to install modus-themes as well as
> many other themes available from ELPA.
> 
> The problem here is with the themes we bundle with Emacs, because these
> are not installed in the normal way (e.g. they're not `load-path` and
> they're not scrubbed by autoload.el).

They are in custom-theme-load-path, right?  So that's what I meant by
supporting themes in package.el: teach it about
custom-theme-load-path, so it could know which themes are bundled.

> > I'd like to keep themes in their current location.  Where this
> > requires additional infrastructure for themes that do something
> > special, I think we should add such an infrastructure.
> 
> The current problem is not due to modus-themes doing something special,
> but to the need to record the version of modus-themes that we bundle so
> that we can compare it to the versions available from ELPA.  The problem
> already existed for other themes, such as `leuven` which we bundle
> without telling package.el.
> 
> I opened a bug for that.

Thanks.



      reply	other threads:[~2021-03-27  6:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 19:52 modus-themes ELPA and etc/themes Stefan Monnier
2021-03-20 20:23 ` Eli Zaretskii
2021-03-20 20:39   ` Stefan Monnier
2021-03-20 21:31     ` Basil L. Contovounesios
2021-03-20 22:49       ` Protesilaos Stavrou
2021-03-21  5:59     ` Eli Zaretskii
2021-03-26 21:41       ` Stefan Monnier
2021-03-27  6:05         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838s69p1vq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).