From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Sat, 24 Jul 2021 18:48:41 +0300 Message-ID: <838s1vzp9i.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <83eebq2mpy.fsf@gnu.org> <83lf5w26e3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23593"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 17:49:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7Ju6-0005wJ-7M for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 17:49:30 +0200 Original-Received: from localhost ([::1]:59252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Ju5-00059Q-9f for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 11:49:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7JtY-0004UV-73 for emacs-devel@gnu.org; Sat, 24 Jul 2021 11:48:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43614) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7JtW-0005eS-Us; Sat, 24 Jul 2021 11:48:54 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1978 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7JtW-0003AT-IQ; Sat, 24 Jul 2021 11:48:54 -0400 In-Reply-To: (message from Yuan Fu on Sat, 24 Jul 2021 11:04:35 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271551 Archived-At: > From: Yuan Fu > Date: Sat, 24 Jul 2021 11:04:35 -0400 > Cc: Stefan Monnier , > Clément Pit-Claudel , > emacs-devel@gnu.org > > I wrote a simple interface between font-lock and tree-sitter, and it works pretty well: using tree-sitter for fontification, xdisp.c opens a lot faster, and scrolling through the buffer is also perceivably faster. My simple interface works like this: tree-sitter allow you to “pattern match” nodes in the parse tree with a DSL, and assign names to the matched nodes, e.g., given a pattern, you get back a list of (NAME . MATCHED-NODE). And if we use font-lock faces as names for those nodes, we get back a list of (FACE . MATCHED-NODE) from tree-sitter, and Emacs can simply look at the beginning and end of the node, and apply FACE to that range. For flexibility, FACE can also be a function, in which case the function is called with the node. This interface is basically what emacs-tree-sitt er does (I don’t know if they allow a capture name to be a function, though.) > > I have an example major-mode for C that uses tree-sitter for font-locking at the end of tree-sitter.el. > > Main functions to look at: tree-sitter-query-capture in tree_sitter.c, and tree-sitter-fontify-region-function in tree-sitter.el. Thanks! > BTW, what is the best way to signal a lisp error from C? I tried xsignal2, signal_error, error and friends but they seem to crash Emacs. Maybe I wasn’t using them correctly. xsignal2 should work, as should xsignal. Please show the code which crashed. > IIUC if we want tree-sitter to use our malloc, we need to build it with Emacs, where should I put the source of tree-sitter? tree-sitter itself should be a library we link against. If you meant the tree-sitter support code, then it should go on a separate file in src/. Or did I misunderstand your question? > What’s the different between make_string and make_pure_c_string? I’ve seen this “pure” thing else where, what does “pure” mean? I suggest to read the node "Pure Storage" in the ELisp manual. It explains that.