From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Better emoji support Date: Mon, 20 Sep 2021 09:53:09 +0300 Message-ID: <838rzr3fhm.fsf@gnu.org> References: <834kd2cypw.fsf@gnu.org> <87zguuttbm.fsf@gmail.com> <8335smcxx6.fsf@gnu.org> <87v95itsc4.fsf@gmail.com> <831r86cxdy.fsf@gnu.org> <83a6kgejp0.fsf@gnu.org> <87wnnkpjj9.fsf@gmail.com> <3E0155F6-D681-4443-A1D9-472D1836168D@traduction-libre.org> <87bl4rnyoe.fsf@gmail.com> <877dffnwf5.fsf@gmail.com> <875yuzciaf.fsf@gmail.com> <87tuijm9uy.fsf@gmail.com> <87lf3v2dz4.fsf@gmail.com> <87ilywl8tx.fsf@gmail.com> <877dfcz6zu.fsf@gmail.com> <83mto73mem.fsf@gnu.org> <87ee9jhint.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38054"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, emacs-devel@gnu.org To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 08:53:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSDBc-0009fC-Dq for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 08:53:56 +0200 Original-Received: from localhost ([::1]:41556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDBa-00039U-MH for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 02:53:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDB0-0002Su-Ia for emacs-devel@gnu.org; Mon, 20 Sep 2021 02:53:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51276) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDAz-0006EZ-SY; Mon, 20 Sep 2021 02:53:18 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDAz-0003ET-FM; Mon, 20 Sep 2021 02:53:17 -0400 In-Reply-To: <87ee9jhint.fsf@gmail.com> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Mon, 20 Sep 2021 08:20:54 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275109 Archived-At: > From: Kévin Le Gouguec > Cc: rpluim@gmail.com, emacs-devel@gnu.org > Date: Mon, 20 Sep 2021 08:20:54 +0200 > > *Right now* (as of commit 995a623594), I'd expect them to be displayed > with Noto Color Emoji, since > > (1) (char-table-range char-script-table ?↔) yields "emoji", > (2) fontset.el indiscriminately slaps "Noto Color Emoji" on the whole > "emoji" script. > > IOW my expectation comes from trying to understand what the code > currently does, not necessarily from thinking it's The Right Thing. Heh, welcome to the club. At this point, we are generally happy if we get the display right, even if we don't understand why the wrong settings of the fontset were effectively ignored ;-) But if you actually want to understand, then the only way is to step through the font-selection code in fontset.c and see why it rejects Noto Color Emoji. If you find anything interesting, please tell us. > IIUC Robert's tentative patch[1] gets us closer to The Right Thing, by > making sure (char-table-range char-script-table C) is "emoji" iff C's > Emoji_Presentation property is "Yes". IMO, that's what we want; the emoji sequences should be handled via composition-function-table, not via the fontset.