From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Compressed *.el files Date: Wed, 22 Sep 2021 18:53:51 +0300 Message-ID: <838rzowqr4.fsf@gnu.org> References: <83ee9gwye0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 22 17:54:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT4Zv-0009hu-RH for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 17:54:35 +0200 Original-Received: from localhost ([::1]:35368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT4Zt-0001Ov-1k for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 11:54:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4ZI-0000kH-Mj for emacs-devel@gnu.org; Wed, 22 Sep 2021 11:53:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40858) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT4ZI-0004CR-8i; Wed, 22 Sep 2021 11:53:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4038 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4ZH-0006e9-Bb; Wed, 22 Sep 2021 11:53:56 -0400 In-Reply-To: (message from Andrea Corallo on Wed, 22 Sep 2021 15:19:40 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275320 Archived-At: > From: Andrea Corallo > Cc: emacs-devel@gnu.org > Date: Wed, 22 Sep 2021 15:19:40 +0000 > > > The function comp-el-to-eln-rel-filename is capable of processing > > compressed *.el.gz files, which is of course needed for working > > correctly in an installed Emacs. However, when it sees a file whose > > name ends in .gz, it invokes the function md5_gz_stream, which is only > > defined if Emacs was built with zlib. Does this have some fallback > > (which I'm missing ATM) for when Emacs was built without zlib, or do > > we need to add something there? > > Hi Eli, > > good point, I guess we should require zlib for > --with-native-compilation. Is this problematic? I don't know if it's problematic. A build without zlib still could use native-compilation, they should just disable compression of the *.el files at "make install" time. So requiring zlib could be too drastic. I will make the changes to fail native compilation if the *.el files are compressed, but zlib isn't available, and will write up something regarding the installation in that case.