unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: emacs-devel@gnu.org
Subject: Re: Compressed *.el files
Date: Wed, 22 Sep 2021 18:53:51 +0300	[thread overview]
Message-ID: <838rzowqr4.fsf@gnu.org> (raw)
In-Reply-To: <xjfy27or62b.fsf@ma.sdf.org> (message from Andrea Corallo on Wed,  22 Sep 2021 15:19:40 +0000)

> From: Andrea Corallo <akrl@sdf.org>
> Cc: emacs-devel@gnu.org
> Date: Wed, 22 Sep 2021 15:19:40 +0000
> 
> > The function comp-el-to-eln-rel-filename is capable of processing
> > compressed *.el.gz files, which is of course needed for working
> > correctly in an installed Emacs.  However, when it sees a file whose
> > name ends in .gz, it invokes the function md5_gz_stream, which is only
> > defined if Emacs was built with zlib.  Does this have some fallback
> > (which I'm missing ATM) for when Emacs was built without zlib, or do
> > we need to add something there?
> 
> Hi Eli,
> 
> good point, I guess we should require zlib for
> --with-native-compilation.  Is this problematic?

I don't know if it's problematic.  A build without zlib still could
use native-compilation, they should just disable compression of the
*.el files at "make install" time.  So requiring zlib could be too
drastic.

I will make the changes to fail native compilation if the *.el files
are compressed, but zlib isn't available, and will write up something
regarding the installation in that case.



  reply	other threads:[~2021-09-22 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 13:08 Compressed *.el files Eli Zaretskii
2021-09-22 15:19 ` Andrea Corallo via Emacs development discussions.
2021-09-22 15:53   ` Eli Zaretskii [this message]
2021-09-22 16:02     ` Andrea Corallo via Emacs development discussions.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rzowqr4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).