From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Wed, 29 Sep 2021 16:41:20 +0300 Message-ID: <838rzfijnj.fsf@gnu.org> References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> <87zgrv33mf.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudiwillalwaysloveyou@gmail.com, stefankangas@gmail.com, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 15:57:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVa5F-00008T-20 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 15:57:17 +0200 Original-Received: from localhost ([::1]:35308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVa5D-0003jL-EJ for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 09:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZpi-0004kk-GE for emacs-devel@gnu.org; Wed, 29 Sep 2021 09:41:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57112) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZpi-0004GP-5x; Wed, 29 Sep 2021 09:41:14 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3529 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZph-000658-G9; Wed, 29 Sep 2021 09:41:13 -0400 In-Reply-To: <87zgrv33mf.fsf@gnu.org> (message from Tassilo Horn on Wed, 29 Sep 2021 15:23:39 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275797 Archived-At: > From: Tassilo Horn > Cc: rudiwillalwaysloveyou@gmail.com, stefankangas@gmail.com, > emacs-devel@gnu.org > Date: Wed, 29 Sep 2021 15:23:39 +0200 > > > Isn't that exactly the problem? If both old_name and new_name exist, > > how do I rename old_name into new_name so that it overwrites new_name > > instead of becoming its subdirectory? I must carefully type new_name > > RET so as to avoid having a slash at its end. > > That's already the case without this patch and emacs 27.2 started with > "emacs -Q". I have both foo and bar directories in my dired buffer, > then hit R on foo and complete bar/. It will move foo inside of bar. > The very same happens if I just complete to bar without trailing /. And with the proposed change, the last sentence will no longer happen, right? That's the change in behavior I was talking about. Or am I missing something?