unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master c9e901f: Avoid small parasitic button on mode line
       [not found] ` <20211206171116.66439209FD@vcs0.savannah.gnu.org>
@ 2021-12-06 17:34   ` Lars Ingebrigtsen
  2021-12-06 17:47     ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-06 17:34 UTC (permalink / raw)
  To: emacs-devel; +Cc: Eli Zaretskii

eliz@gnu.org (Eli Zaretskii) writes:

>     Avoid small parasitic button on mode line
>
>     * lisp/bindings.el (mode-line-position): Remove stray space
>     character, which caused a "ghost" button on the mode line.
>     (Bug#52332)

The space was added with the following commit message:

    Add temporary mode-line-position change
    
    * lisp/bindings.el (mode-line-position): Add interim solution to
    make `min-width' work here; this should be fixed for real in the
    display_line machinery somewhere.


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master c9e901f: Avoid small parasitic button on mode line
  2021-12-06 17:34   ` master c9e901f: Avoid small parasitic button on mode line Lars Ingebrigtsen
@ 2021-12-06 17:47     ` Eli Zaretskii
  2021-12-06 18:20       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2021-12-06 17:47 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 06 Dec 2021 18:34:40 +0100
> 
> eliz@gnu.org (Eli Zaretskii) writes:
> 
> >     Avoid small parasitic button on mode line
> >
> >     * lisp/bindings.el (mode-line-position): Remove stray space
> >     character, which caused a "ghost" button on the mode line.
> >     (Bug#52332)
> 
> The space was added with the following commit message:
> 
>     Add temporary mode-line-position change
>     
>     * lisp/bindings.el (mode-line-position): Add interim solution to
>     make `min-width' work here; this should be fixed for real in the
>     display_line machinery somewhere.

You want that ghost button back?  That space is what caused it.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master c9e901f: Avoid small parasitic button on mode line
  2021-12-06 17:47     ` Eli Zaretskii
@ 2021-12-06 18:20       ` Lars Ingebrigtsen
  2021-12-06 18:30         ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-06 18:20 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> You want that ghost button back?  That space is what caused it.

I want min-width to be fixed, but, yes, until that's done, the ghost
button should stay.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master c9e901f: Avoid small parasitic button on mode line
  2021-12-06 18:20       ` Lars Ingebrigtsen
@ 2021-12-06 18:30         ` Eli Zaretskii
  2021-12-06 18:32           ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2021-12-06 18:30 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Mon, 06 Dec 2021 19:20:27 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > You want that ghost button back?  That space is what caused it.
> 
> I want min-width to be fixed, but, yes, until that's done, the ghost
> button should stay.

What is exactly the problem we have without that blank?



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master c9e901f: Avoid small parasitic button on mode line
  2021-12-06 18:30         ` Eli Zaretskii
@ 2021-12-06 18:32           ` Lars Ingebrigtsen
  2021-12-06 18:50             ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-06 18:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> What is exactly the problem we have without that blank?

The `min-width' doesn't work at all without that blank, last time I
checked, but it's been a week, so for all I know it works again now.

I'll have some time to work more on this later this week (unless you get
to it first).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: master c9e901f: Avoid small parasitic button on mode line
  2021-12-06 18:32           ` Lars Ingebrigtsen
@ 2021-12-06 18:50             ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2021-12-06 18:50 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Mon, 06 Dec 2021 19:32:42 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > What is exactly the problem we have without that blank?
> 
> The `min-width' doesn't work at all without that blank, last time I
> checked, but it's been a week, so for all I know it works again now.

OK, I reverted it.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-12-06 18:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211206171115.20126.37465@vcs0.savannah.gnu.org>
     [not found] ` <20211206171116.66439209FD@vcs0.savannah.gnu.org>
2021-12-06 17:34   ` master c9e901f: Avoid small parasitic button on mode line Lars Ingebrigtsen
2021-12-06 17:47     ` Eli Zaretskii
2021-12-06 18:20       ` Lars Ingebrigtsen
2021-12-06 18:30         ` Eli Zaretskii
2021-12-06 18:32           ` Lars Ingebrigtsen
2021-12-06 18:50             ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).