unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuri D'Elia <wavexx@thregr.org>
Cc: larsi@gnus.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca,
	dgutov@yandex.ru
Subject: Re: Incorrect font weight selected
Date: Wed, 05 Jan 2022 21:07:10 +0200	[thread overview]
Message-ID: <838rvu9f35.fsf@gnu.org> (raw)
In-Reply-To: <87mtkaujbs.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Wed, 05 Jan 2022 19:08:21 +0100)

> From: Yuri D'Elia <wavexx@thregr.org>
> Cc: dgutov@yandex.ru, monnier@iro.umontreal.ca, larsi@gnus.org,
>  emacs-devel@gnu.org
> Date: Wed, 05 Jan 2022 19:08:21 +0100
> 
> > I don't think this would be correct, since frames are supposed to be
> > independent wrt faces.
> 
> MMh, yes, and no? I definitely understand this reasoning, and we need to
> support that no questions here. But purely as as user, when I'm editing
> with multiple frames and I change the default font I certainly want all
> old and new frames to change as a result, which is why we have this odd
> dance.

Your expectations are in general incorrect.  They are due to the fact
that calling set-face-font and similar APIs without the optional FRAME
argument arranges for the change to affect all frames.  But the
low-level code which implements set-face-font only changes the face of
a single frame, and doesn't touch the face definition on other frames.
And the default font generally stands for the font of the default face
of the frame on which you change that face, so it, too, doesn't
necessarily affect other frames.  When we look at low-level code such
as this one, we should always keep that in mind, and avoid leaking the
face definitions to other frames.  The trick of making the change take
effect on other frames is implemented by higher levels.

This is the general background that makes me uneasy to accept the
changes which you suggested, because they seem to violate that general
principle on a very low level.



  reply	other threads:[~2022-01-05 19:07 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 14:51 Incorrect font weight selected Yuri D'Elia
2021-12-17 18:55 ` Eli Zaretskii
2021-12-17 19:47   ` Yuri D'Elia
2021-12-17 20:27     ` Eli Zaretskii
2021-12-17 21:25       ` Yuri D'Elia
2021-12-18  6:32         ` Eli Zaretskii
2021-12-18 10:43           ` Yuri D'Elia
2021-12-18 11:41             ` Eli Zaretskii
2021-12-18 12:00               ` Yuri D'Elia
2021-12-18 12:49                 ` Eli Zaretskii
2021-12-19 11:14                   ` Yuri D'Elia
2021-12-19 12:46                     ` Eli Zaretskii
2021-12-19 13:17                       ` Yuri D'Elia
2021-12-19 13:32                         ` Lars Ingebrigtsen
2021-12-19 23:24         ` Yuri D'Elia
2021-12-20 10:34           ` Lars Ingebrigtsen
2021-12-20 19:43             ` Stefan Monnier
2021-12-20 19:52               ` Eli Zaretskii
2021-12-20 20:14                 ` Stefan Monnier
2021-12-20 20:19                   ` Eli Zaretskii
2021-12-21  4:22                     ` Dmitry Gutov
2021-12-21 12:18                       ` Eli Zaretskii
2021-12-21 12:27                         ` Yuri D'Elia
2021-12-21 14:19                           ` Eli Zaretskii
2022-01-05 16:19                             ` Yuri D'Elia
2022-01-05 17:05                               ` Eli Zaretskii
2022-01-05 17:11                                 ` Yuri D'Elia
2022-01-05 18:04                                   ` Eli Zaretskii
2022-01-05 18:08                                     ` Yuri D'Elia
2022-01-05 19:07                                       ` Eli Zaretskii [this message]
2022-01-05 23:16                                         ` Yuri D'Elia
2022-01-06  7:09                                           ` Eli Zaretskii
2022-01-06  9:46                                             ` Yuri D'Elia
2022-01-06 12:22                                               ` Eli Zaretskii
2022-01-05 21:57                                       ` Dmitry Gutov
2022-01-05 23:15                                         ` Yuri D'Elia
2022-01-05 23:15                                         ` Yuri D'Elia
2022-01-06  5:15                                       ` Sean Whitton
2022-01-06  0:41                               ` Po Lu
2022-01-06  0:54                                 ` Po Lu
2022-01-06  9:49                                 ` Yuri D'Elia
2022-01-06 12:21                                   ` Eli Zaretskii
2021-12-21 13:52                       ` John ff
2021-12-20 20:05               ` Stefan Monnier
2021-12-20 15:16           ` Eli Zaretskii
2021-12-18 23:26 ` Sean Whitton
2021-12-19  6:44   ` Eli Zaretskii
2021-12-19 11:29     ` Yuri D'Elia
2021-12-19 12:52       ` Eli Zaretskii
2021-12-19 12:57         ` Yuri D'Elia
2021-12-19 13:32           ` Eli Zaretskii
2021-12-19 21:03         ` Sean Whitton
2021-12-19 22:04           ` Yuri D'Elia
2021-12-19 22:39             ` Sean Whitton
2021-12-20 21:59           ` Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rvu9f35.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=wavexx@thregr.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).