From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling. Date: Tue, 26 Jul 2022 14:07:38 +0300 Message-ID: <838rogdtdx.fsf@gnu.org> References: <165799889678.19490.7919197387382513250@vcs2.savannah.gnu.org> <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org> <87o7xgcb0a.fsf@tcd.ie> <83fsishsnb.fsf@gnu.org> <8a3eaeef017c4ad4da7d@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 26 13:12:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGIUY-0004v3-FA for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 13:12:46 +0200 Original-Received: from localhost ([::1]:48072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGIUX-0006Q4-98 for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 07:12:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGIPZ-0001Ne-1l for emacs-devel@gnu.org; Tue, 26 Jul 2022 07:07:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGIPW-000073-3l; Tue, 26 Jul 2022 07:07:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oRSp/CnDARTtFdvQASwc9awGzVxnCJolrivLk8K8FSg=; b=NtBUIED9k4Uisd9Jeuo3 v6M/8u2sfnk9sArBHMEAm1eNJNVij9mLSbKfQi2YHTdniJ1ZdLylaX2a+RqHSx/UGpoLKPw+Yho7A v3IBWUctuTRuc/REwBVDpMfnWy/LVJRRSa8TPrxo4XaEnW+ejSW/nvya8mrUSOqIcHVzseiSTTzwx ToeESpxvqnsqhArgfWDYRxeOaLQ77quR7c8w9tT4UvLfuqjfyEknLxrpagIsAFGfTfvL62xlaCRWU GPlSanDfQrMpC24JgaWbRKnbrn7rmJLIaYouJgEPZWhh6yBkTirMT//b3xB1n+aOrVXaFbyEF1gAc rbctH3ABA3PxSg==; Original-Received: from [87.69.77.57] (port=4513 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGIPV-0002Qu-Ha; Tue, 26 Jul 2022 07:07:33 -0400 In-Reply-To: <8a3eaeef017c4ad4da7d@heytings.org> (message from Gregory Heytings on Mon, 25 Jul 2022 20:50:02 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292672 Archived-At: > Date: Mon, 25 Jul 2022 20:50:02 +0000 > From: Gregory Heytings > cc: "Basil L. Contovounesios" , emacs-devel@gnu.org > > >> This seems to have given rise to the following build error with --enable-checking=structs: > >> > >> pdumper.c: In function ‘dump_buffer’: > >> pdumper.c:2705:3: error: #error "buffer changed. See CHECK_STRUCTS comment in config.h." > >> 2705 | # error "buffer changed. See CHECK_STRUCTS comment in config.h." > >> | ^~~~~ > >> > >> Is this the right fix? > > > > Yes, thanks. > > > > Thanks. But how comes this warning did not show up in my > --enable-checking=all build? I don't know. Is CHECK_STRUCTS set to 'true' in src/Makefile in that build of yours? If not, we may have a bug in configure.ac or elsewhere.