From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: c-ts-mode: (eq treesit-font-lock-level 2) doesn't fontify parameter names. Date: Sat, 04 Feb 2023 20:19:22 +0200 Message-ID: <838rhdthsl.fsf@gnu.org> References: <85fc0396-bf75-c059-3871-80a5cae8ab94@yandex.ru> <83bkm9ti2n.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7094"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: dgutov@yandex.ru Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 04 19:19:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pON8m-0001ba-PV for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Feb 2023 19:19:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pON8O-0006WN-PV; Sat, 04 Feb 2023 13:19:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pON8F-0006VZ-UM for emacs-devel@gnu.org; Sat, 04 Feb 2023 13:19:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pON8B-0002yr-TK; Sat, 04 Feb 2023 13:19:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Gb1gOVn99NTx/MLsVy5JSqfBwnK0M/QGCQKCF3rXq5M=; b=eOG5BjGCqPb9 nd9lBXm/nTE0WpyfhIjQBPIR7It6ZXCI57LydnagLBzp9eorYSyUE3tmuKLMloDtL11tcHs2FcZR6 xaDEFeWtf+FhJ99fouHEHx9NiWsG9YGaWQ08eJSlgirXYICIZhDtkDMo+liiIaAybmtyBjhVQVQrm uKUhSJoR+5UeKcXO3lkw+p8UXx5oVpCWjmlTtJusnt5SagTw/6VHbYXVsfkSAMkC6i0gDuxJJ5HW9 givoTMm7n/JcZ4m1gVfrLEnNfDYm9jy2WuiwhRHc2ST99IDXQZIJdyjZBe2U2dvknPkHW5oEAXiIn sfAhi02xlS0X2a5fEIqDNw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pON86-000674-F4; Sat, 04 Feb 2023 13:19:19 -0500 In-Reply-To: <83bkm9ti2n.fsf@gnu.org> (message from Eli Zaretskii on Sat, 04 Feb 2023 20:13:20 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302975 Archived-At: > Date: Sat, 04 Feb 2023 20:13:20 +0200 > From: Eli Zaretskii > Cc: acm@muc.de, emacs-devel@gnu.org > > > Date: Sat, 4 Feb 2023 19:32:11 +0200 > > From: Dmitry Gutov > > > > On 04/02/2023 16:49, Alan Mackenzie wrote: > > > Setting treesit-font-lock-level to 2 for c-ts-mode fontifies variable > > > definitions, but not parameter definitions. > > > > The patch below seems to fix that (the functionality was basically > > implemented already). I suggest we install it on emacs-29, for > > consistency with other modes, among other things. > > AFAIU, this patch will fontify variables in function parameter lists > at level 1, not 2, but I don't mind. Btw, we should probably do the same for C++ and Java.