From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New Git hooks for checking file names in commit messages Date: Sat, 22 Apr 2023 10:51:31 +0300 Message-ID: <838rek2w3g.fsf@gnu.org> References: <5e494275-d253-118a-4a40-86d252285a23@gmail.com> <83pm7w30pg.fsf@gnu.org> <19cf70fa-22fc-213b-e2d3-610f8e6cc165@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: john@yates-sheets.org, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 22 09:52:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pq82O-0004ck-Jr for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Apr 2023 09:52:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pq81g-00007G-Pt; Sat, 22 Apr 2023 03:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq81b-000072-Fj for emacs-devel@gnu.org; Sat, 22 Apr 2023 03:51:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq81a-00049g-Az; Sat, 22 Apr 2023 03:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pWc5cnYg805ReLRgRSDzUWOTR29L4Ou0rZwiRGRf16k=; b=kZv9SfCl1ADH Ano9LL5sAkDWU01EMrNK72nvnmHOKamCSQIj80XERozHF1lSdVa1Kvk4paeAWDchSWL3JYHuDo28N k9qQwhY574YZtMZZl0/YNVnDUhKMpckEVpv+EGxGKtT7xhGw7+lzq+kAYOS2IJ6mg6CSnBpLyPCgK Zj5OZP2iJuyG6uQoTa1vlTFA/hjL9lDZ6ihM31AhG5TDFim+1ceP9HaPvscZrQ6wPby8UZLn1rIuN 7TjIsAJkbuSPgRE6O7LAo+hcVbovY/Qu69dK7lipcVGdEKf7gbti3CjneueMQlLalA2yw/+9jer7M T9EQ8X+6etgjuo9+EJPpvw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq81Y-0001Bh-Na; Sat, 22 Apr 2023 03:51:13 -0400 In-Reply-To: <19cf70fa-22fc-213b-e2d3-610f8e6cc165@gmail.com> (message from Jim Porter on Fri, 21 Apr 2023 23:59:33 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305575 Archived-At: > Date: Fri, 21 Apr 2023 23:59:33 -0700 > Cc: john@yates-sheets.org, emacs-devel@gnu.org > From: Jim Porter > > On 4/21/2023 11:11 PM, Eli Zaretskii wrote: > >> Date: Fri, 21 Apr 2023 10:44:10 -0700 > >> From: Jim Porter > >> Cc: emacs-devel@gnu.org, eliz@gnu.org > >> > >> Eli, what do you think? I've run this against the 5000 latest commits > >> and the results look right (though I haven't looked as thoroughly as > >> last time). > > > > I think the hooks should follow the GNU Standards (which are also our > > conventions), not their particular expressions in algorithms used by > > authors.el. > > I *think* in this case, the two are the same... or at least the relevant > algorithms in authors.el are consistent with the GNU standards. I don't > see a strict set of rules in the GNU standards, so I had to make some > guesses based on the examples and the implementation in authors.el. The programmatic expression of the standards is in add-log.el, I think.