From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: make check produces 25 failures and hangs (bug #65176). Date: Sun, 13 Aug 2023 15:07:59 +0300 Message-ID: <838rafcfhc.fsf@gnu.org> References: <9e9bf73a-f7e8-24e2-bd3f-5f4e86baa65e@vodafonemail.de> <83zg2ygmwu.fsf@gnu.org> <7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19922"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org, luangruo@yahoo.com To: Jens Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 13 14:08:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qV9tt-00051G-1A for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Aug 2023 14:08:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qV9tA-0005uO-Od; Sun, 13 Aug 2023 08:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qV9t9-0005uF-Ib for emacs-devel@gnu.org; Sun, 13 Aug 2023 08:08:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qV9t6-0000Zg-Q4; Sun, 13 Aug 2023 08:08:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tqwh3z3MFkud8Mms8ULqInkhqLoJjJHvCix7sgQeVj4=; b=dzWt6NOpGR+K 2Rc5GzPhEtJyi9nQpNnNVVZhGG9ji8rVClALf/QB9+EBRgXKfbSCH75Sm0bptovvo5acPSrtAgt61 yuZmoPmwDPeD0gvpNsE+eQ2xIAKDQE3MUbN5+HgE1JlLTarVJLIxWPI+N+q9r3d8QIAT1k1TuqDsk LrC3mo++xBb/Chh8HW766iijEDGz6rXa6PqJShZe01TntmVq73HTq68T85a+ZSvJ8BrR9VKbXRQIu gRVzfMGlaHysUmZ/ZDSmHqiQgNNrWwZQc4hmPCi5JfpRUQMJcc5wl/M9A2Ip6ae98w6v+sS096bf1 8rUGObpikRDsS1Qbq49FXg==; In-Reply-To: <7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de> (message from Jens Schmidt on Sun, 13 Aug 2023 12:59:26 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308672 Archived-At: > Date: Sun, 13 Aug 2023 12:59:26 +0200 > Cc: acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org, > Po Lu > From: Jens Schmidt > > On 2023-08-12 21:09, Andrea Corallo wrote: > > > To a very quick look seems to me `comp-subr-trampoline-install' is just > > not called as it should. AFAIR it should be called from Ffset, I'm > > really wondering what could have happened. > > Probably because native-comp-enable-subr-trampolines equals nil in an > "emacs-master -Q"? > > When I compare the following snippet from emacs-master/lisp/loadup.el: > > (when (and (featurep 'native-compile) > (equal dump-mode "pdump")) > ;; Don't enable this before bootstrap is completed, as the > ;; compiler infrastructure may not be usable yet. > (setq comp-enable-subr-trampolines t)) > ^^^^ > > to emacs-29: > > (when (and (featurep 'native-compile) > (equal dump-mode "pdump")) > ;; Don't enable this before bootstrap is completed, as the > ;; compiler infrastructure may not be usable yet. > (setq native-comp-enable-subr-trampolines t)) > ^^^^^^^^^^^ These two are supposed to be aliases (the comp-enable-subr-trampolines one is the old name, the other one is the new name). If the alias is missing, we should restore it, in addition to fixing the name we use in startup.el.