From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Interest in a Cosmopolitan build? Date: Thu, 09 Nov 2023 07:44:17 +0200 Message-ID: <838r771nwu.fsf@gnu.org> References: <83ttpw1lzw.fsf@gnu.org> <784ffc8ae66e600ffbc598232cbc1abea9e55788.camel@corcoles.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alex Corcoles Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 09 06:45:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0xqj-0000zY-3d for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Nov 2023 06:45:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0xqA-00085b-IG; Thu, 09 Nov 2023 00:44:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0xq7-00085N-0f for emacs-devel@gnu.org; Thu, 09 Nov 2023 00:44:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0xq6-000445-G8; Thu, 09 Nov 2023 00:44:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=l5XXXS7Oej9TGCRS/yIMQoq0WZNmCIOS5tPhHqOyJoU=; b=AR9Y/5K1oHFxy87m4Mso wFNYWOwOzU4V8iAA7/FDf8cugRup8ktj7ZY1bLQuL6Qp1JUC7veK+9tg2LHJ981a8w6xyhDxRNOiI YJo6NnlFnjyaZBy/L9xKALHt3l62I1XPDsxQtxDge1Ni2c5faeETlB8f1C9xRr7aIjn755XKNpmgp rjCOYCADvJc8AZNfEEe9CFT5VR3/h9XXBLxvJo1AEay3fhshhpQvbsH8wUigHMM4QCyMwYbUfIeLR mLShiynTj9VF/AZD6Mm7oXtPu92GSbmz0P9sDZitZQl2P7Euw4zKk3zXGcSKgpTMx0BL1dXuI/CTv tHavlsHEwh5Q5g==; In-Reply-To: <784ffc8ae66e600ffbc598232cbc1abea9e55788.camel@corcoles.net> (message from Alex Corcoles on Wed, 08 Nov 2023 21:11:51 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312380 Archived-At: > From: Alex Corcoles > Cc: emacs-devel@gnu.org > Date: Wed, 08 Nov 2023 21:11:51 +0100 > > > Can you post the patches here?  I'd prefer not to point people to > > GitHub. > > Not sure if this will come out OK: Thanks, but can you explain the reasons for these changes? They look strange to me. E.g., why do you care which symbol is #undef'ed here: > /* Define to read input using SIGIO. */ > -#undef INTERRUPT_INPUT > +#undef INTERRUPT_INPUT0 Or why do you need to avoid using enum here: > --- ./emacs-29.1/src/filelock.c 2023-01-01 14:46:43.000000000 +0100 > +++ ./emacs-29.1/src/filelock.c.new 2023-11-04 17:53:19.163803983 > +0100 > @@ -298,7 +298,7 @@ > There is no way to tell whether a symlink call fails due to > permissions issues or because links are not supported, but luckily > the lock file code should work either way. */ > -enum { LINKS_MIGHT_NOT_WORK = EPERM }; > +#define LINKS_MIGHT_NOT_WORK EPERM > +/* Another process on this machine owns it. */ > +#define ANOTHER_OWNS_IT (NEGATIVE_ERRNO ? 1 : -1) > + > +/* This Emacs process owns it. */ > +#define I_OWN_IT (2 * ANOTHER_OWNS_IT) This sounds like a kludgey solution fopr some problem, but what is the problem? Are these all the changes you need, or just a sample?