From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dan.colascione@gmail.com>
Cc: emacs-devel@gnu.org, jasonr@gnu.org
Subject: Re: Fixing Windows and DOS command line argument quoting
Date: Mon, 25 Apr 2011 21:47:08 +0300 [thread overview]
Message-ID: <837hai9nir.fsf@gnu.org> (raw)
In-Reply-To: <4DB5B5B7.3070801@gmail.com>
> Date: Mon, 25 Apr 2011 10:56:07 -0700
> From: Daniel Colascione <dan.colascione@gmail.com>
> Cc: emacs-devel@gnu.org
>
> After another reading of cmdproxy.c, I also see that the CreateProcess
> path also doesn't expand environment %variable% references, and that
> doesn't fall back to cmd if the command to be executed contains them.
> While we could expand these variables, doing so would move us even
> closer to reimplementing half of cmd.exe.
We don't want to reimplement cmd.exe, that's for sure. I would say,
if it's easy to detect that case, just make that another condition for
going through the shell. If it isn't easy to detect, we can always
say that these commands must be explicitly run through "cmd /c" by the
application. After all, that's not a frequent use case in Emacs,
because Emacs always expands environment variables before running the
command, and if it doesn't, it surely won't use the %foo% syntax. So
about the only use case for this is a Lisp application that directly
targets Windows -- and those could be told to go through cmd
explicitly.
> I'd like to remove this path in the trunk and see whether the new
> 8192-character length limitation is a problem in practice.
No, I don't think it's a good idea. 8K is too low by any measure; we
already hit the shell limitations once or twice when related problems
were discussed.
What are the disadvantages of detecting quoted command lines and
sending only those through the shell?
next prev parent reply other threads:[~2011-04-25 18:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 2:09 Fixing Windows and DOS command line argument quoting Daniel Colascione
2011-04-25 6:41 ` Eli Zaretskii
2011-04-25 8:49 ` Daniel Colascione
2011-04-25 8:58 ` Jason Rumney
2011-04-25 9:15 ` Eli Zaretskii
2011-04-25 9:22 ` Daniel Colascione
2011-04-25 17:56 ` Daniel Colascione
2011-04-25 18:47 ` Eli Zaretskii [this message]
2011-04-26 10:44 ` Daniel Colascione
2011-04-26 17:50 ` Eli Zaretskii
2011-04-25 9:35 ` Eli Zaretskii
2011-04-25 18:24 ` Daniel Colascione
2011-04-25 18:48 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2011-04-27 0:58 Ben Key
2011-04-27 1:25 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837hai9nir.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dan.colascione@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).