From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: File watch support in autorevert.el Date: Sat, 12 Jan 2013 13:31:43 +0200 Message-ID: <837gnitz6o.fsf@gnu.org> References: <878v819kok.fsf@gmx.de> <83fw28uj9c.fsf@gnu.org> <87mwwfmij0.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1357990288 18111 80.91.229.3 (12 Jan 2013 11:31:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2013 11:31:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 12 12:31:46 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TtzJQ-0000lU-01 for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2013 12:31:44 +0100 Original-Received: from localhost ([::1]:54222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtzJ9-0006wq-TR for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2013 06:31:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtzJ6-0006wE-C4 for emacs-devel@gnu.org; Sat, 12 Jan 2013 06:31:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtzJ3-0006qv-T8 for emacs-devel@gnu.org; Sat, 12 Jan 2013 06:31:24 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:46630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtzJ3-0006qe-Kz for emacs-devel@gnu.org; Sat, 12 Jan 2013 06:31:21 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MGI00G00FY5Z700@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sat, 12 Jan 2013 13:31:20 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MGI00GWOG07VV20@a-mtaout23.012.net.il>; Sat, 12 Jan 2013 13:31:20 +0200 (IST) In-reply-to: <87mwwfmij0.fsf@gmx.de> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156260 Archived-At: > From: Michael Albinus > Cc: emacs-devel@gnu.org > Date: Sat, 12 Jan 2013 00:01:07 +0100 > > Eli Zaretskii writes: > > > . For that reason, I think auto-revert-notify-handler should > > filter events by ASPECTS/ACTION member, and on Windows also by FILE > > member of the event. > > I have added first checks. Hopefully, they do not break the w32notify case. I needed to make 2 changes to get this to work on Windows, see trunk revision 111499. Actually, I don't understand how it worked with inotify before my changes, since you were looking for 'modify' in the descriptor rather than in the action. Did I miss something? Btw, should we perhaps do something more sophisticated than string-equal to compare file names? On Windows, we probably should compare case-insensitively, but what about file-truename and friends on Posix platforms?