From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: implementing curl module with opaque emacs types Date: Sun, 15 Feb 2015 21:47:08 +0200 Message-ID: <837fvjufcz.fsf@gnu.org> References: <83y4oiiw81.fsf@gnu.org> <838ugdf251.fsf@gnu.org> <54D80098.3020209@cs.ucla.edu> <54D85304.1030600@cs.ucla.edu> <54D9AC29.2020603@cs.ucla.edu> <54DA8539.1020905@cs.ucla.edu> <87zj8ktq8f.fsf@lifelogs.com> <54DD6413.1000403@cs.ucla.edu> <83wq3m436s.fsf@gnu.org> <834mqowbnh.fsf@gnu.org> <85egpsgf5z.fsf@stephe-leake.org> <83oaovull2.fsf@gnu.org> <85y4nzat5m.fsf@stephe-leake.org> <85egprasb7.fsf_-_@stephe-leake.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1424029654 10730 80.91.229.3 (15 Feb 2015 19:47:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Feb 2015 19:47:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 15 20:47:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YN59z-0007kR-RH for ged-emacs-devel@m.gmane.org; Sun, 15 Feb 2015 20:47:19 +0100 Original-Received: from localhost ([::1]:36416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YN59z-0005oE-E3 for ged-emacs-devel@m.gmane.org; Sun, 15 Feb 2015 14:47:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YN59r-0005hL-4x for emacs-devel@gnu.org; Sun, 15 Feb 2015 14:47:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YN59m-0000zY-9o for emacs-devel@gnu.org; Sun, 15 Feb 2015 14:47:11 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:47814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YN59m-0000zJ-1t for emacs-devel@gnu.org; Sun, 15 Feb 2015 14:47:06 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJT00C00VZN0900@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sun, 15 Feb 2015 21:47:04 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJT00BYBWAGMS90@a-mtaout22.012.net.il>; Sun, 15 Feb 2015 21:47:04 +0200 (IST) In-reply-to: <85egprasb7.fsf_-_@stephe-leake.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183117 Archived-At: > From: Stephen Leake > Date: Sun, 15 Feb 2015 13:27:40 -0600 > > Here is the list of Emacs functions that curl.c currently uses > > Fprovide > SSDATA > XSAVE_POINTER > builtin_lisp_symbol (for Qnil) > defsubr > intern > make_string It also uses XSAVE_VALUE (called by XSAVE_POINTER) and save_type and die, indirectly via eassert, when ENABLE_CHECKING is defined. Btw, its use of make_string is incorrect: it should use make_unibyte_string string and then decode it. Which will require more functions. Likewise with SSDATA: the string that is used as a URL should be encoded before it is passed to libcurl functions.