From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix tramp test Date: Sun, 22 Feb 2015 18:00:44 +0200 Message-ID: <837fvac4wj.fsf@gnu.org> References: <54E9CAA6.8010205@cumego.com> <871tlighi6.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1424620867 20096 80.91.229.3 (22 Feb 2015 16:01:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Feb 2015 16:01:07 +0000 (UTC) Cc: esperanto@cumego.com, emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 22 17:01:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YPYxp-0001pG-Aj for ged-emacs-devel@m.gmane.org; Sun, 22 Feb 2015 17:01:01 +0100 Original-Received: from localhost ([::1]:40462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPYxo-0001qA-SK for ged-emacs-devel@m.gmane.org; Sun, 22 Feb 2015 11:01:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPYxb-0001pr-8n for emacs-devel@gnu.org; Sun, 22 Feb 2015 11:00:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPYxX-0004QW-Tc for emacs-devel@gnu.org; Sun, 22 Feb 2015 11:00:47 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:50168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPYxX-0004QE-Cl for emacs-devel@gnu.org; Sun, 22 Feb 2015 11:00:43 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NK600C00KCMKK00@mtaout28.012.net.il> for emacs-devel@gnu.org; Sun, 22 Feb 2015 17:59:06 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK60037GKEIV180@mtaout28.012.net.il>; Sun, 22 Feb 2015 17:59:06 +0200 (IST) In-reply-to: <871tlighi6.fsf@gmx.de> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183386 Archived-At: > From: Michael Albinus > Date: Sun, 22 Feb 2015 15:14:57 +0100 > Cc: emacs-devel@gnu.org > > > A tiny patch for a test that fails in non English systems. OS output summary is > > language dependent and for example in Polish it displays "razem 1234" instead of > > "total 1234". > > > > Please let me know if it can't be applied for some reason. > > > > diff --git a/test/automated/tramp-tests.el b/test/automated/tramp-tests.el > > index 2c4610c..e60a13f 100644 > > --- a/test/automated/tramp-tests.el > > +++ b/test/automated/tramp-tests.el > > @@ -955,7 +955,7 @@ This tests also `file-directory-p' and `file-accessible-directory-p'." > > (looking-at-p > > (concat > > ;; There might be a summary line. > > - "\\(total.+[[:digit:]]+\n\\)?" > > + "\\([[:alpha:]].+[[:digit:]]+\n\\)?" > > Better might be "\\([[:alpha:]]+[[:blank:]]+[[:digit:]]+\n\\)?" IMO, [:alpha:] is too indiscreet: it will match almost anything, except in pure ASCII range. Including some error message, for example. So I think it would be much better to keep the literal "total", and instead set LC_MESSAGES=en_US.UTF-8, or something similar.