From: Eli Zaretskii <eliz@gnu.org>
To: David Kastrup <dak@gnu.org>
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: master 5022e27: ; Do not overwrite preexisting contents of unread-command-events
Date: Sat, 08 Aug 2015 13:18:32 +0300 [thread overview]
Message-ID: <837fp6qe13.fsf@gnu.org> (raw)
In-Reply-To: <87fv3ui0h3.fsf@fencepost.gnu.org>
> From: David Kastrup <dak@gnu.org>
> Cc: rgm@gnu.org, emacs-devel@gnu.org
> Date: Sat, 08 Aug 2015 11:38:32 +0200
>
> Well, the question is just what this entry should entail. Every changed
> function and file?
Yes.
> That will be a rather large entry.
It's not a problem. We have our share of such large entries already.
> Apart from that I don't think I need to "wait for the update to
> ChangeLog.2" since the complaint was that the log message was formatted
> in a way where it would not even cause an entry to ChangeLog.2. So it
> doesn't really seem to matter all that much just when I'll update
> ChangeLog.2 manually.
Right.
> Well, the changes are mostly of the "similar minor change" kind, namely
> not completely obeying the same description.
Nevertheless, I think it should be possible to come up with some text
that would allow you to have a single entry for all of those changes.
> The main problem I have is that the invested work and the resulting
> space in the ChangeLog is not going to save anybody any time or effort
> since we are not talking about a feature here or normally user-visible
> changes in semantics. And it's not particular to any package/feature
> either. It's not the kind of change we are maintaining a ChangeLog file
> separate from commit messages for.
I think our rule is to have ChangeLog entries for all non-trivial
changes whose description carries significant information. Basically,
anything that people might want looking up in order to understand why
was the change done. I think your changes qualify.
> The reason I made that simple commit message really wasn't "oh, I'm too
> lazy to do a proper one" but rather "this would not even make sense".
> Obviously other developers disagree after the fact so I'll "fix" it. I
> just have a hard time doing a fix that does not feel like making the
> situation worse than it is already.
Something like this:
* file1 (func1, func2, func3):
* file2 (func4, func5):
* file3 (func6, func7, func8, func9): Minor improvements in how
events are added to unread-command-events.
shouldn't make things worse, and should be fairly easy to write, I
think.
next prev parent reply other threads:[~2015-08-08 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150804124300.13374.78396@vcs.savannah.gnu.org>
[not found] ` <E1ZMbYa-0003UO-69@vcs.savannah.gnu.org>
2015-08-04 15:30 ` master 5022e27: ; Do not overwrite preexisting contents of unread-command-events Glenn Morris
2015-08-04 15:52 ` David Kastrup
2015-08-08 8:33 ` David Kastrup
2015-08-08 9:11 ` Eli Zaretskii
2015-08-08 9:38 ` David Kastrup
2015-08-08 10:18 ` Eli Zaretskii [this message]
2015-08-08 14:17 ` Stefan Monnier
2015-08-08 15:04 ` David Kastrup
2015-08-08 16:08 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837fp6qe13.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).