From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: merging the xwidget_mvp branch Date: Wed, 04 Nov 2015 17:29:06 +0200 Message-ID: <837flxvl4t.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1446651008 18537 80.91.229.3 (4 Nov 2015 15:30:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Nov 2015 15:30:08 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, joakim@verona.se, emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 04 16:29:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zu00c-0003wx-Bh for ged-emacs-devel@m.gmane.org; Wed, 04 Nov 2015 16:29:58 +0100 Original-Received: from localhost ([::1]:55389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu00b-0004C3-Jf for ged-emacs-devel@m.gmane.org; Wed, 04 Nov 2015 10:29:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu00X-0004Bm-SS for emacs-devel@gnu.org; Wed, 04 Nov 2015 10:29:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zu00T-0004lC-RB for emacs-devel@gnu.org; Wed, 04 Nov 2015 10:29:53 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:60516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu00T-0004kS-JF for emacs-devel@gnu.org; Wed, 04 Nov 2015 10:29:49 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NXA00400QMGML00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 04 Nov 2015 17:29:07 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXA004W8R0JI830@a-mtaout22.012.net.il>; Wed, 04 Nov 2015 17:29:07 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193204 Archived-At: > From: John Wiegley > Date: Tue, 03 Nov 2015 16:51:39 -0500 > Cc: monnier@IRO.UMontreal.CA, Emacs developers >=20 > > The patch is large I suppose. It mostly affects the redisplay sys= tem. >=20 > It's unfortunate that that is currently one of our most complex sub= systems, > where we've had the greatest difficulty finding other contributors.= I'd like > to know Eli's opinion on this especially, since he is actively main= taining > that code. Actually, most of the changes are in the X-specific back-end of the display engine, something I almost never dive into. (I have no easy access to an X-based Unix system where I can run and debug GUI programs.) The display-independent parts of the patch are relatively minor and closely follow the footsteps of displaying images, so maintaining tha= t part shouldn't be a problem: just remember to do for xwidgets whateve= r we do for images. There is, of course, the point that this is X- and GTK3-specific, so will only be available on some systems (and some people deliberately avoid building with GTK even where it is available because it causes crashes), but I guess this cannot be helped. > > I have maintained it in its own branch for a couple of years. I c= an continue > > doing that in master, or in its own branch indefinitely. >=20 > I'm personally inclined to not want this feature, unless there is a= great deal > of desire for it from others; so I'll wait for them chime in. Well, at the time there was a lot of excitement, as I understand this feature is considered rather "cool" nowadays. See, for example http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00077.html I'll let people who are familiar with the relevant use cases, first and foremost Joakim himself, describe when and how this is useful. M= y personal impression from past discussions was that the question whether to reject this was never on the table; it was always the assumption that we want this feature, nd will merge it as soon as it'= s ready. > I hate to say no given how much effort you've put into it, but ther= e needs to > be enough value to offset the additional technical debt we'd be acc= ruing. In these discussions: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg02191.html http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00012.html there were some suggestions for cleaning up the code. I've took a brief look at the branch as it is now, and most of the problems were addressed, but I still see a lot of TODOs and FIXMEs, some temporary comments, some commented-out code, at least one 'printf' in xdisp.c, etc. Also, many doc strings in xwidget.c "need work"=E2=84=A2. This= needs to be cleaned up, I think (but can be done after the merge to master, of course). Bottom line: I see no reasons not to merge this.