From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Fri, 20 Nov 2015 23:22:24 +0200 Message-ID: <837flc5ptb.fsf@gnu.org> References: <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> <837fld6lps.fsf@gnu.org> <83r3jk6fw6.fsf@gnu.org> <83k2pc6537.fsf@gnu.org> <564F84E5.2050801@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448054592 24440 80.91.229.3 (20 Nov 2015 21:23:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Nov 2015 21:23:12 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, p.stephani2@gmail.com, tzz@lifelogs.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 20 22:23:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zzt8x-0005Gz-O6 for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 22:22:55 +0100 Original-Received: from localhost ([::1]:49929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzt8w-0007k7-HN for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 16:22:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzt8j-0007jB-CE for emacs-devel@gnu.org; Fri, 20 Nov 2015 16:22:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zzt8g-0003VU-8c for emacs-devel@gnu.org; Fri, 20 Nov 2015 16:22:41 -0500 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:54087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzt8g-0003Ub-0O for emacs-devel@gnu.org; Fri, 20 Nov 2015 16:22:38 -0500 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NY400B00TDTTI00@mtaout24.012.net.il> for emacs-devel@gnu.org; Fri, 20 Nov 2015 23:15:30 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NY400674TPTIP60@mtaout24.012.net.il>; Fri, 20 Nov 2015 23:15:30 +0200 (IST) In-reply-to: <564F84E5.2050801@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194902 Archived-At: > Cc: p.stephani2@gmail.com, aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, > emacs-devel@gnu.org > From: Paul Eggert > Date: Fri, 20 Nov 2015 12:39:01 -0800 > > Eli Zaretskii wrote: > > I suspect the push_handlers changes in aa7dac8. > > No, it was the reindenting change! I got confused by the do-while indenting in a > complicated macro. Fixed in commit 95f69f2c5999be4b9444861b6d4ae1bd3ab87f83. Thanks, the tests now pass here as well. > I didn't notice all these problems because I wasn't running that test. I was > just doing 'make check'. Philipp, shouldn't mod-test.c part of 'make check', > when Emacs is configured --with-modules? Also, shouldn't the mod-test.c Makefile > use the same GCC warning flags etc. that everyone else does? That would help > catch these bugs better. Yes, on both counts. It's a matter of time to settle all that, though.