From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master dbb29d7: Add info-lookup help for
	gdb-script-mode
Date: Sun, 05 Feb 2017 17:28:11 +0200
Message-ID: <837f548xo4.fsf@gnu.org>
References: <20170117224028.8928.65103@vcs.savannah.gnu.org>
	<20170117224028.A68812201B9@vcs.savannah.gnu.org>
	<jwvlgu9yqpr.fsf-monnier+emacsdiffs@gnu.org>
	<87d1flhtow.fsf@tromey.com>
	<jwvr34030xj.fsf-monnier+emacsdiffs@gnu.org>
	<87zii18cm8.fsf@tromey.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1486308538 22731 195.159.176.226 (5 Feb 2017 15:28:58 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sun, 5 Feb 2017 15:28:58 +0000 (UTC)
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
To: Tom Tromey <tom@tromey.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 05 16:28:55 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1caOkH-0005h7-Ss
	for ged-emacs-devel@m.gmane.org; Sun, 05 Feb 2017 16:28:53 +0100
Original-Received: from localhost ([::1]:43572 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1caOkN-0006hn-7n
	for ged-emacs-devel@m.gmane.org; Sun, 05 Feb 2017 10:28:59 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1caOjr-0006hg-2f
	for emacs-devel@gnu.org; Sun, 05 Feb 2017 10:28:27 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1caOjn-0007dl-W6
	for emacs-devel@gnu.org; Sun, 05 Feb 2017 10:28:27 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35787)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1caOjn-0007dh-TY; Sun, 05 Feb 2017 10:28:23 -0500
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3635
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1caOjm-0005zR-H5; Sun, 05 Feb 2017 10:28:23 -0500
In-reply-to: <87zii18cm8.fsf@tromey.com> (message from Tom Tromey on Sat, 04
	Feb 2017 21:50:39 -0700)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:211996
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/211996>

> From: Tom Tromey <tom@tromey.com>
> Date: Sat, 04 Feb 2017 21:50:39 -0700
> Cc: Tom Tromey <tom@tromey.com>, emacs-devel@gnu.org
> 
> I took a stab at this tonight and would appreciate your feedback.
> My initial patch is appended.

Thanks.

I think with such massive refactoring we need regression tests to go
with the changes.  Could you write some tests, please?