From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: phst@google.com, p.stephani2@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Reimplement module functions
Date: Sun, 14 May 2017 17:11:22 +0300 [thread overview]
Message-ID: <837f1j8r5h.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV-_kLnjxESRjBFZuwroo_jek=_VXs5c3-NWp_pVtyvygNg@mail.gmail.com> (message from Noam Postavsky on Sat, 13 May 2017 23:07:26 -0400)
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 13 May 2017 23:07:26 -0400
> Cc: Philipp Stephani <p.stephani2@gmail.com>, Philipp Stephani <phst@google.com>,
> Emacs developers <emacs-devel@gnu.org>
>
> > I don't think we can simply remove a function that was already present
> > in one or more Emacs releases. We need to provide a backward
> > compatibility layer, and definitely also mention this in NEWS.
>
> Does an internal function like 'internal--module-call' really need all
> that? AFAIK, it was not really meant to be used except in the
> implementation of module_make_function.
We don't _have_ to do that, but if it's not too hard, why not be nice
to our users and keep providing it? Maybe I'm missing something, but
it seemed to me that a simple wrapper around funcall_module or its
part would do. We can declare it obsolete and remove it at some
future point.
next prev parent reply other threads:[~2017-05-14 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 14:44 [PATCH] Reimplement module functions Philipp Stephani
2017-05-13 17:05 ` Eli Zaretskii
2017-05-14 3:07 ` Noam Postavsky
2017-05-14 14:11 ` Eli Zaretskii [this message]
2017-05-14 11:40 ` Aurélien Aptel
2017-05-14 14:30 ` Eli Zaretskii
2017-05-14 18:08 ` Philipp Stephani
2017-05-14 18:09 ` Philipp Stephani
2017-05-20 13:37 ` Philipp Stephani
2017-05-20 20:46 ` Paul Eggert
2017-05-21 20:20 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837f1j8r5h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=npostavs@users.sourceforge.net \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).