From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: CSS contrast (#30295) (was Re: Heads-up: Emacs 26.1 RC1) Date: Wed, 21 Mar 2018 09:38:14 +0200 Message-ID: <837eq5lvyx.fsf@gnu.org> References: <83muz2lfo9.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521617771 1454 195.159.176.226 (21 Mar 2018 07:36:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Mar 2018 07:36:11 +0000 (UTC) Cc: johnw@gnu.org, tom@tromey.com, emacs-devel@gnu.org To: Richard Copley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 21 08:36:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyYI1-0000I8-RZ for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 08:36:05 +0100 Original-Received: from localhost ([::1]:53307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyYK5-0004TQ-5p for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 03:38:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyYJz-0004T2-6u for emacs-devel@gnu.org; Wed, 21 Mar 2018 03:38:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyYJy-0005yf-DN for emacs-devel@gnu.org; Wed, 21 Mar 2018 03:38:07 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyYJt-0005wP-8i; Wed, 21 Mar 2018 03:38:01 -0400 Original-Received: from [176.228.60.248] (port=1821 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eyYJs-0003hn-M1; Wed, 21 Mar 2018 03:38:01 -0400 In-reply-to: (message from Richard Copley on Tue, 20 Mar 2018 19:56:12 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223877 Archived-At: > From: Richard Copley > Date: Tue, 20 Mar 2018 19:56:12 +0000 > Cc: John Wiegley , Tom Tromey , > Emacs Development > > Patch 1 is a small fix for the current formula using color-distance. > Patch 2 uses luminance as in Tom's original patch. > I think patch 2 gives better contrast. Thanks, but I think this is a step backward, as it more or less goes back to the code before the discussion of bug#25525. How about making the threshold a customizable value instead, with the current hard-coded value the default? That'd be compatible, and should allow you to get the contrast of your liking.