From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: emacs-26 eec71eb: Speed up replace-buffer-contents
Date: Tue, 03 Jul 2018 22:28:39 +0300 [thread overview]
Message-ID: <837emcjezc.fsf@gnu.org> (raw)
In-Reply-To: <698fc242-71bf-0e6e-5e45-d1be45cbc074@cs.ucla.edu> (message from Paul Eggert on Mon, 2 Jul 2018 23:25:03 -0700)
> Cc: Eli Zaretskii <eliz@gnu.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 2 Jul 2018 23:25:03 -0700
>
> Glenn Morris wrote:
> > This didn't merge cleanly to master; please could you check I didn't
> > mess it up...
>
> Looks OK to me, though Eli is better positions to check.
Looks OK to me too. Thanks for merging, Glenn.
> Probably could tune that code more. I'll see if I can spring free some time to
> do that.
I just made a simple change that sped up the bug#31888 recipe by 30%.
Profiling shows that 'diag' takes 32% of the CPU time, and
buffer_chars_equal takes another 45%. So any significant gains will
be in buffer_chars_equal, I think.
next prev parent reply other threads:[~2018-07-03 19:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180629135646.6054.66405@vcs0.savannah.gnu.org>
[not found] ` <20180629135648.5C95A2053B@vcs0.savannah.gnu.org>
2018-07-03 2:25 ` emacs-26 eec71eb: Speed up replace-buffer-contents Glenn Morris
2018-07-03 6:25 ` Paul Eggert
2018-07-03 19:28 ` Eli Zaretskii [this message]
2018-07-03 20:14 ` Paul Eggert
2018-07-04 2:31 ` Eli Zaretskii
2018-07-04 6:36 ` Paul Eggert
2018-07-04 15:09 ` Eli Zaretskii
2018-07-04 18:30 ` Paul Eggert
2018-07-04 18:40 ` Eli Zaretskii
2018-07-07 11:57 ` Eli Zaretskii
2018-07-07 18:22 ` Paul Eggert
2018-07-07 18:40 ` Eli Zaretskii
2018-07-04 16:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837emcjezc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).