From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: ari.roponen@gmail.com, emacs-devel@gnu.org
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Mon, 17 Dec 2018 19:39:33 +0200 [thread overview]
Message-ID: <837eg8dpd6.fsf@gnu.org> (raw)
In-Reply-To: <m2d0q0com0.fsf@gmail.com> (message from Robert Pluim on Mon, 17 Dec 2018 13:41:11 +0100)
> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org, ari.roponen@gmail.com
> Date: Mon, 17 Dec 2018 13:41:11 +0100
>
> >> Aligning ftfont.c and ftcrfont.c is pretty easy. Did you want me to
> >> try to unify xftfont.c in there as well?
> >
> > If that makes sense, i.e. if the commonality seems to justify that,
> > then yes.
> >
>
> I had a quick go at this. Iʼve not measured the memory difference, but
> I can do if people thinks this refactor is worth it. Apart from the
> unification of the three struct definitions, most of the patch is
> mechanical changes.
Thanks, this LGTM, and is a significant improvement, IMO. If no one
objects in a few days, please push.
P.S. Will this have any problems with the harfbuzz branch?
next prev parent reply other threads:[~2018-12-17 17:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181214085417.15440.18845@vcs0.savannah.gnu.org>
[not found] ` <20181214085418.6616820538@vcs0.savannah.gnu.org>
2018-12-14 12:18 ` harfbuzz 2f72162: Fix crash in the Cairo build Robert Pluim
2018-12-14 13:29 ` Eli Zaretskii
2018-12-14 14:09 ` Robert Pluim
2018-12-14 16:16 ` Robert Pluim
2018-12-14 16:45 ` Eli Zaretskii
2018-12-17 12:41 ` Robert Pluim
2018-12-17 17:39 ` Eli Zaretskii [this message]
2018-12-18 8:49 ` Robert Pluim
2018-12-18 13:01 ` Robert Pluim
2019-02-08 8:01 ` Robert Pluim
2019-02-08 8:04 ` Robert Pluim
2019-02-08 8:06 ` Robert Pluim
2019-02-08 9:37 ` Eli Zaretskii
2019-02-08 11:46 ` Robert Pluim
2019-02-08 13:14 ` Eli Zaretskii
2019-02-08 14:38 ` Robert Pluim
2019-02-08 16:11 ` Eli Zaretskii
2019-02-08 16:41 ` Robert Pluim
2019-02-08 21:29 ` Eli Zaretskii
2019-02-09 19:20 ` Glenn Morris
2019-02-09 19:34 ` Eli Zaretskii
2019-02-10 14:47 ` Stefan Monnier
2019-02-10 15:28 ` Eli Zaretskii
2019-02-10 18:18 ` Stefan Monnier
2019-02-10 18:48 ` Eli Zaretskii
2019-02-10 18:52 ` Stefan Monnier
2019-02-11 9:56 ` Robert Pluim
2019-02-10 18:30 ` Glenn Morris
2019-02-10 14:57 ` Eli Zaretskii
2019-02-10 18:36 ` Glenn Morris
2019-02-11 15:33 ` Eli Zaretskii
2018-12-17 21:49 ` Paul Eggert
2018-12-18 8:23 ` Robert Pluim
2018-12-19 8:32 ` Robert Pluim
2018-12-19 15:06 ` Eli Zaretskii
2018-12-14 20:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837eg8dpd6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ari.roponen@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).