From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix `early-init-file' value when file is missing Date: Fri, 08 Feb 2019 23:52:30 +0200 Message-ID: <837eeaosm9.fsf@gnu.org> References: <8336p7zxdf.fsf@gnu.org> <83bm3mrazc.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="252880"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Radon Rosborough Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 22:53:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsE5k-0013dD-Ln for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 22:53:48 +0100 Original-Received: from localhost ([127.0.0.1]:35733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsE5j-0002cn-Ju for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 16:53:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsE4p-0002bg-So for emacs-devel@gnu.org; Fri, 08 Feb 2019 16:52:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsE4p-0006HD-Of; Fri, 08 Feb 2019 16:52:51 -0500 Original-Received: from [176.228.60.248] (port=4356 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gsE4p-00068X-4c; Fri, 08 Feb 2019 16:52:51 -0500 In-reply-to: (message from Radon Rosborough on Fri, 8 Feb 2019 09:34:08 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233146 Archived-At: > From: Radon Rosborough > Date: Fri, 8 Feb 2019 09:34:08 -0800 > Cc: emacs-devel > > > However, I would prefer to have this solved outside > > load-user-init-file, if feasible. This function is too central to > > Emacs to make non-trivial changes there for such a minor problem's > > sake. > > I am sorry, but I simply cannot see how this change is non-trivial. > There is exactly one logic change that this patch makes: namely, that > the extension of user-init-file is changed to .el, but only in the > case of the early init-file not being found. But to do that, you've modified the API of load-user-init-file, changing the semantics of its second argument, which then caused the code of the function to change to accommodate that. This then requires to go and check that these changes didn't affect the other callers of that function in ways we don't want. > I also cannot see how any other way of solving this bug could be as > clear and straightforward as fixing it directly by updating the code > that was broken. All you want is to set a single variable to a specific value if the file wasn't found, right? How hard can it be to do that after load-user-init-file returns and reports a failure? Or do that inside the function, but only if it processes early-init file specifically? > Could you explain your reasoning? I tried in the message you responded to, but you've elided all those explanations.