From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] v2: Fixes to allow erc-dcc-get-filter to work properly Date: Fri, 15 Feb 2019 10:18:46 +0200 Message-ID: <837ee1o461.fsf@gnu.org> References: <3FCFBDED-9040-41B1-9686-30773CA6EC08.notmuch@neverland> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236720"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Victor Orlikowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 15 09:19:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1guYi6-000zOs-NY for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2019 09:19:02 +0100 Original-Received: from localhost ([127.0.0.1]:34210 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guYi5-0004kH-Jy for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2019 03:19:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guYhz-0004k0-Nu for emacs-devel@gnu.org; Fri, 15 Feb 2019 03:18:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guYhu-0007N8-CL; Fri, 15 Feb 2019 03:18:52 -0500 Original-Received: from [176.228.60.248] (port=2804 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1guYht-0002EE-C6; Fri, 15 Feb 2019 03:18:49 -0500 In-reply-to: <3FCFBDED-9040-41B1-9686-30773CA6EC08.notmuch@neverland> (message from Victor Orlikowski on Sun, 10 Feb 2019 19:14:26 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233357 Archived-At: > From: Victor Orlikowski > Date: Sun, 10 Feb 2019 19:14:26 +0000 > > When using erc-dcc-get-filter with erc-dcc-verbose set to t, message > errors prevent the DCC get from completing correctly. > > The attached patch adds some additional error checking to > erc-dcc-get-filter, and uses ethe function buffer-name in place of > the variable buffer-file-name (which appears to be nil in this > context, which thereby causes the message errors). > > >From cd390337b8e819248568b900e6115dde8a19fde9 Mon Sep 17 00:00:00 2001 > From: "Victor J. Orlikowski" > Date: Sun, 10 Feb 2019 11:13:57 -0500 > Subject: [PATCH] Perform additional validation in erc-dcc-get-filter, and use > the function buffer-name rather than buffer-file-name (which is actually nil > in this context). Thanks, I pushed this to the emacs-26 branch. For the future, please note the following 2 gotchas: . The title of your patch (in the Subject) was too long, and our Git commit hooks rejected it. It should be a single line, not ending in a period, and it should not exceed 79 characters . You didn't provide ChangeLog-style entries for the changes you made, which mention the modified function(s) and what was changed in each one. This is described in more detail in CONTRIBUTE, which I suggest to read. Thanks again for working on this.