From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Mon, 18 Mar 2019 05:35:43 +0200 Message-ID: <837ecwx3ao.fsf@gnu.org> References: <20190318010313.rec67ljatygf5xlf@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204148"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 18 04:36:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5j4D-000qxd-4V for ged-emacs-devel@m.gmane.org; Mon, 18 Mar 2019 04:36:01 +0100 Original-Received: from localhost ([127.0.0.1]:35227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5j4C-0001iT-4E for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 23:36:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5j46-0001gE-2R for emacs-devel@gnu.org; Sun, 17 Mar 2019 23:35:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5j45-0008UV-RN; Sun, 17 Mar 2019 23:35:54 -0400 Original-Received: from [176.228.60.248] (port=2415 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5j44-0002Zs-H7; Sun, 17 Mar 2019 23:35:53 -0400 In-reply-to: <20190318010313.rec67ljatygf5xlf@Ergus> (message from Ergus on Mon, 18 Mar 2019 02:03:13 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234315 Archived-At: > Date: Mon, 18 Mar 2019 02:03:13 +0100 > From: Ergus > Cc: emacs-devel@gnu.org > > The variable fill-column is defined in the buffer.c file. I should > access it in every display_line when display-fill-column is enabled if I > want to keep the difference between display-fill-column-indicator-column > and fill-column. (when display-fill-column-indicator is t). > > Whats the better method to do that? Are you worried about performance? If so, then don't: accessing a single variable is not something that would slow down redisplay in any tangible way. So I don't recommend any more complex solution that somehow caches the fill-column value, it isn't justified in this case.